Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Table#upsert #1

Merged
merged 2 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/kotlin/de/mineking/database/DataObject.kt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ interface DataObject<T: Any> {

fun insert() = getTable().insert(this as T)
fun update() = getTable().update(this as T)
fun upsert() = getTable().upsert(this as T)
fun delete() = getTable().delete(this as T)

fun <O: Any> selectReferring(table: Table<O>, reference: String, where: Where = Where.EMPTY): QueryResult<O> {
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/kotlin/de/mineking/database/Table.kt
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ interface Table<T: Any> {
fun update(column: String, value: Node, where: Where = Where.EMPTY): UpdateResult<Int>

fun insert(obj: T): UpdateResult<T>
fun upsert(obj: T): UpdateResult<T>

fun delete(where: Where = Where.EMPTY): Int
fun delete(obj: T) = delete(identifyObject(obj))
}
Expand All @@ -64,8 +66,6 @@ abstract class TableImplementation<T: Any>(
) : Table<T>, InvocationHandler {
override val implementation: TableImplementation<T> = this

abstract fun createSelect(columns: String, where: Where, order: Order?, limit: Int?, offset: Int?): String

open fun parseResult(context: ReadContext): Boolean {
if (!context.proceed()) return false

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class PostgresTable<T: Any>(
""") + createJoinList(it.reference!!.structure.columns, prefix + it.name) }
}

override fun createSelect(columns: String, where: Where, order: Order?, limit: Int?, offset: Int?): String = """
private fun createSelect(columns: String, where: Where, order: Order?, limit: Int?, offset: Int?): String = """
select $columns
from ${ structure.name }
${ createJoinList(structure.columns.reversed()).joinToString(" ") }
Expand Down Expand Up @@ -229,8 +229,38 @@ class PostgresTable<T: Any>(

val sql = """
insert into ${ structure.name }
(${columns.joinToString { "\"${it.name}\"" }})
values(${columns.joinToString { ":${it.name}" }})
(${ columns.joinToString { "\"${ it.name }\"" } })
values(${ columns.joinToString { ":${ it.name }" } })
returning *
""".trim().replace("\\s+".toRegex(), " ")

return createResult {
structure.manager.driver.withHandleUnchecked { executeUpdate(it.createUpdate(sql), obj) }
if (obj is DataObject<*>) obj.afterRead()
obj
}
}

override fun upsert(obj: T): UpdateResult<T> {
if (obj is DataObject<*>) obj.beforeWrite()

val insertColumns = structure.getAllColumns().filter {
if (!it.getRootColumn().autogenerate) true
else {
val value = it.get(obj)
value != 0 && value != null
}
}

val updateColumns = structure.getAllColumns().filter { !it.getRootColumn().key }


val sql = """
insert into ${ structure.name }
(${ insertColumns.joinToString { "\"${ it.name }\"" } })
values(${ insertColumns.joinToString { ":${ it.name }" } })
on conflict (${ structure.getKeys().joinToString { "\"${ it.name }\"" } }) do update set
${ updateColumns.joinToString { "\"${ it.name }\" = :${ it.name }" } }
returning *
""".trim().replace("\\s+".toRegex(), " ")

Expand Down
54 changes: 54 additions & 0 deletions postgres/src/test/kotlin/tests/postgres/general/Upsert.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
package tests.postgres.general

import de.mineking.database.*
import de.mineking.database.vendors.PostgresConnection
import org.junit.jupiter.api.Test
import setup.ConsoleSqlLogger
import setup.recreate
import kotlin.test.assertEquals
import kotlin.test.assertTrue

data class UpsertDao(
@AutoGenerate @Key @Column val id1: Int = 0,
@AutoGenerate @Key @Column val id2: Int = 0,
@Column val name: String = "",
@Unique @Column val email: String = ""
)

class UpsertTest {
val connection = PostgresConnection("localhost:5432/test", user = "test", password = "test")
val table = connection.getTable(name = "upsert_test") { UpsertDao() }

val entries = listOf(
UpsertDao(name = "Tom", email = "[email protected]"),
UpsertDao(name = "Alex", email = "[email protected]"),
UpsertDao(name = "Bob", email = "[email protected]"),
UpsertDao(name = "Eve", email = "[email protected]"),
UpsertDao(name = "Max", email = "[email protected]")
)

init {
table.recreate()

entries.forEach { table.upsert(it) }

connection.driver.setSqlLogger(ConsoleSqlLogger)
}

@Test
fun checkInsert() {
assertEquals(5, table.selectRowCount())
}

@Test
fun update() {
assertTrue(table.upsert(entries[0].copy(name = "Test")).isSuccess())
assertEquals("Test", table.select<String>(property("name"), where = property("id1") isEqualTo value(1)).first())
}

@Test
fun notUpdated() {
assertTrue(table.upsert(entries[0].copy(email = "[email protected]")).isError())
assertEquals("[email protected]", table.select<String>(property("email"), where = property("id1") isEqualTo value(1)).first())
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class SQLiteTable<T: Any>(
TODO("Not yet implemented")
}

override fun createSelect(columns: String, where: Where, order: Order?, limit: Int?, offset: Int?): String = """
private fun createSelect(columns: String, where: Where, order: Order?, limit: Int?, offset: Int?): String = """

""".trim().replace("\\s+".toRegex(), " ")

Expand All @@ -72,6 +72,10 @@ class SQLiteTable<T: Any>(
TODO("Not yet implemented")
}

override fun upsert(obj: T): UpdateResult<T> {
TODO("Not yet implemented")
}

override fun delete(where: Where): Int {
TODO("Not yet implemented")
}
Expand Down