Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement coremod detection fixer, and an AT remapper #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheCurle
Copy link

See RetroGradle#1 for details, but the short version:

  • FML uses a system property called fml.coreMods.load to discover coremods, which used to be filled by FG2.
    This is now filled by LegacyDev.
  • FML+FG2 uses a FMLAT property in the jar manifest to look for AT files. This searches for those files and adds them manually.
  • FML requires mappings files to do runtime remapping, this used to be set by FG2, so we use the Legacy Extension of RetroGradle's ForgeGradle (RetroGradle/ForgeGradle@c1c537d) to put these mappings in a usable place.

This therefore requires aforementioned ForgeGradle extensions to be useful.

This fixes:

  • Mod coremods not being discovered
  • Mod ATs not being remapped or discovered properly

@@ -0,0 +1,286 @@
/*
* LegacyDev
* Copyright (c) 2016-2020.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I am wrong but I don't think this or any of the added files have the second line of the license match the change to the LICENSE-header.txt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're changing the header, we should just move to the simplified header like we have for the rest of the projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants