Use named pipe to terminate MiniZinc on Windows #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the same approach that the MiniZinc IDE uses to terminate MiniZinc on Windows, by writing to a named pipe created by MiniZInc. Fixes MiniZinc#191
Dekker1
force-pushed
the
windows_pipe_terminate
branch
from
6afac14 to
40635e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using
CTRL_Corproc.terminate(), which is apparently unreliable, write to the special named pipe created by MiniZInc to trigger termination. This is the same approach used in the MiniZincIDE (as GUI applications also can't send CTRL_C events.Fixes #191