-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stt output to input prompt area #3269
base: master
Are you sure you want to change the base?
add stt output to input prompt area #3269
Conversation
FWIW, it used to be this way, then people wanted it to autosubmit, now this PR would change it back |
Can we implement two modes:
|
I get this, but I feel for a non-native english speaking (like myself) it may be useful
I was thinking having this configuration in Settings but this may also work. @timothycarambat any thoughts on this approach? |
@timothycarambat is there any chance a feature like this (or something similar) can be included? |
@therealtimex That kind of UX is ambiguous and is bound to be non-discoverable. Will have to make this a setting in the Voice and Speech area or elsewhere so that we can stop flip-flipping PRs every couple months on this. |
Agreed, setting is always a safe bet. |
added a checkbox for Autosubmit in Voice and Speech settings section - output.mp4 |
Pull Request Type
Relevant Issues
resolves #3268
What is in this change?
Stopped sending voice command directly as prompt to LLM provider so that user can get a chance to edit or add to it if there was a long pause while speaking.
Additional Information
Before -
before.mov
Now -
after.mov
Additionally fixed a minor typo:
endTTSSession
->endSTTSession
Developer Validations
yarn lint
from the root of the repo & committed changes