Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fetch wikis for gitlab data connectors #3271

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lcgash
Copy link
Contributor

@lcgash lcgash commented Feb 19, 2025

Pull Request Type

  • [ ✔️] ✨ feat
  • [ ✔️] 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

What is in this change?

fix some bug && support fetch gitlab wikis

Additional Information

Developer Validations

image

image

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • [✔️ ] I have tested my code functionality
  • Docker build succeeds locally

Copy link
Collaborator

@shatfield4 shatfield4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was able to pull in a wiki file from gitlab with this modification.

@lcgash lcgash requested a review from shatfield4 February 28, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants