Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manager to view roles (workspace) #3284

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

timothycarambat
Copy link
Member

@timothycarambat timothycarambat commented Feb 19, 2025

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #3282

What is in this change?

  • Allow the manager role to view the models in a dropdown while on workspace settings.
  • Additional security on customModels to only persist a passed ApiKey when the role is null (no auth mode) or the role is explicitly ROLE.admin. null role is okay here since to get to this function the middleware does the proper auth checks.

TODO:

  • If I am a manager and I attempt to pick an LLM that has not been configured, the credential modal should not appear since that update will fail and the details will not persist.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Allow manager role to view models for known providers, but not update
2 participants