Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs and local helm registry #12

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Algeran
Copy link
Collaborator

@Algeran Algeran commented Dec 23, 2024

  • Simple docker registry is deployed to the kind cluster as OCI Helm registry, exposed to the local machine with the NodePort on 30500
  • Added docker daemon installation on Linux-based systems
  • Added notes about make help to the README.md
  • Added docs with detailed explanation for General setup steps
  • Fixed helm package bug with missing templates directory (added .gitkeep files)

@Algeran Algeran force-pushed the iivchenkov/local-helm-registry branch 2 times, most recently from de85f20 to 14b2af3 Compare December 27, 2024 12:00
Copy link
Collaborator

@soerenschneider soerenschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, however question(s) about the helmRepo remain.

setup/helmRepository.yaml Outdated Show resolved Hide resolved
setup/helmRepository.yaml Outdated Show resolved Hide resolved
setup/helmRepository.yaml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@Algeran Algeran force-pushed the iivchenkov/local-helm-registry branch 2 times, most recently from 7b76873 to 633cbe8 Compare December 30, 2024 16:19
- Simple docker registry is deployed to the kind cluster as OCI Helm registry, exposed to the local machine with the NodePort on 30500
- Added docker daemon installation on Linux-based systems
- Added notes about `make help` to the README.md
- Added docs with detailed explanation for General setup steps
- Fixed helm package bug with missing templates directory (added .gitkeep files)
@Algeran Algeran force-pushed the iivchenkov/local-helm-registry branch from 633cbe8 to 5f889fb Compare December 30, 2024 16:20
@soerenschneider
Copy link
Collaborator

LGTM, you can merge it.

@Algeran Algeran merged commit c8e2d03 into Mirantis:main Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants