Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track deployment status #196

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Track deployment status #196

merged 2 commits into from
Aug 28, 2024

Conversation

eromanova
Copy link
Member

@eromanova eromanova commented Aug 15, 2024

Added a new poller to track the deployments status in the heartbeat event according to the tracking plan every 10 minutes.

Performance testing

To analyse and decrease memory and CPU usage the following approaches were tested on 1000 test deployments:

Testing discovered that the first approach performed best on the management cluster. It was tested using the metrics server (kubectl top pod):

  1. List all deployments using the default (cached) manager client
NAMESPACE            NAME                                            CPU           Memory
hmc-system           hmc-controller-manager-58bbbc8d7c-wkpfs         6m            67Mi
kube-system          kube-apiserver-hmc-dev-control-plane            82m           562Mi
  1. List all deployments using uncached manager client
NAMESPACE            NAME                                            CPU           Memory
hmc-system           hmc-controller-manager-d8c546f54-667gh          11m           92Mi
kube-system          kube-apiserver-hmc-dev-control-plane            189m          589Mi
  1. Use pagination to list limited blocks of deployments with cached client. Rejected since pagination does not work using cached manager client Pagination does not work when using manager client  kubernetes-sigs/controller-runtime#1960

  2. Use pagination to list limited blocks of deployments with uncached client

NAMESPACE            NAME                                            CPU           Memory
hmc-system           hmc-controller-manager-6b598b4745-c9tp8         10m           61Mi
kube-system          kube-apiserver-hmc-dev-control-plane            120m          666Mi

Closes #138
Closes #231

@eromanova eromanova requested a review from Kshatrix August 15, 2024 12:34
@eromanova eromanova self-assigned this Aug 15, 2024
@eromanova eromanova marked this pull request as draft August 20, 2024 07:13
@eromanova eromanova marked this pull request as ready for review August 21, 2024 15:14
@eromanova eromanova marked this pull request as draft August 22, 2024 08:50
@eromanova eromanova marked this pull request as ready for review August 22, 2024 12:32
internal/telemetry/event.go Outdated Show resolved Hide resolved
internal/telemetry/tracker.go Show resolved Hide resolved
@eromanova eromanova marked this pull request as draft August 23, 2024 15:50
@eromanova eromanova marked this pull request as ready for review August 26, 2024 08:17
@Kshatrix Kshatrix merged commit 7a38a61 into Mirantis:main Aug 28, 2024
1 check passed
@eromanova eromanova deleted the telemetry branch August 29, 2024 14:09
bnallapeta pushed a commit to bnallapeta/hmc that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Make telemetry disableable Heartbeat event to track Deployment status
4 participants