-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CAPI operator to manage providers #224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eromanova
force-pushed
the
capi-operator
branch
from
August 23, 2024 09:40
2a8281e
to
7e4aa9f
Compare
eromanova
force-pushed
the
capi-operator
branch
from
August 23, 2024 09:57
7e4aa9f
to
bd17433
Compare
eromanova
requested review from
squizzi,
kylewuolle,
Kshatrix,
a13x5,
wahabmk and
slysunkin
August 23, 2024 09:58
Kshatrix
requested changes
Aug 23, 2024
Kshatrix
reviewed
Aug 23, 2024
eromanova
force-pushed
the
capi-operator
branch
2 times, most recently
from
August 26, 2024 12:08
826cb13
to
844cb44
Compare
eromanova
force-pushed
the
capi-operator
branch
from
August 27, 2024 08:32
844cb44
to
05b9847
Compare
Disabled by default. It'll be enabled later by the hmc controller once the cert manager is ready. Also, overwride the default controller resource requests and limits since default values are not enough and the pod gets OOMKilled when creating the provider with manifestPatches. Closes Mirantis#215
Since CAPA requires exactly AWS_B64ENCODED_CREDENTIALS key
eromanova
force-pushed
the
capi-operator
branch
from
August 27, 2024 13:41
05b9847
to
951f7c3
Compare
Kshatrix
approved these changes
Aug 28, 2024
bnallapeta
pushed a commit
to bnallapeta/hmc
that referenced
this pull request
Nov 15, 2024
Use CAPI operator to manage providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Providers configuration
The CAPI operator allows passing
configSecret
with all the configuration variables: https://doc.crds.dev/github.com/kubernetes-sigs/cluster-api-operator/operator.cluster.x-k8s.io/InfrastructureProvider/[email protected]#spec-configSecretHMC provider templates were adapted to either pass a pre-created configuration secret name and namespace or receive the configuration parameters as helm chart values (the secret with the provided configuration will be automatically created). This PR introduces the common structure for passing providers' additional parameters.
Examples:
configSecret
configuration is unset, the provider will be deployed with the defaults.Closes #214
Closes #215