Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend helm chart configuration for Templates #699

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Extend helm chart configuration for Templates #699

merged 1 commit into from
Dec 10, 2024

Conversation

eromanova
Copy link
Member

@eromanova eromanova commented Nov 28, 2024 •
edited
Loading

This PR introduces the following changes in the ClusterTemplate, ServiceTemplate, and ProviderTemplate spec:

  • New spec.helm.chartSpec section of the HelmChartSpec type to support providing extended helm chart configuration. An example of the simplest allowed configuration:
spec:
  helm:
    chartSpec:
      chart: chart-name

An example of the extended configuration with the source

spec:
  helm:
    chartSpec:
      chart: chart-name
      version: 1.0.0
      interval: 15m0s
      sourceRef:
        kind: HelmRepository
        name: helm-repo

The version parameter is optional (the latest chart version will be used if unset). The sourceRef and interval parameters from the spec.helm.chart will be automatically populated with defaults if unset:

interval: 10m0s
sourceRef:
  kind: HelmRepository
  name: hmc-templates

where hmc-templates is the name of the default HelmRepository created by the hmc controller.

  • The spec.helm.chartName and spec.helm.chartVersion parameters were removed as unnecessary.

Closes #615

@eromanova eromanova self-assigned this Nov 28, 2024
@eromanova eromanova marked this pull request as ready for review November 29, 2024 12:00
@eromanova eromanova marked this pull request as draft December 2, 2024 15:49
@eromanova eromanova marked this pull request as ready for review December 3, 2024 12:14
zerospiel
zerospiel previously approved these changes Dec 3, 2024
View reviewed changes
zerospiel
zerospiel previously approved these changes Dec 6, 2024
View reviewed changes
eromanova added a commit to eromanova/project-2a-docs that referenced this pull request Dec 9, 2024
@eromanova
Update BYO templates documentation
a708fe4 
Relates to Mirantis/hmc#615

Related hmc core changes: Mirantis/hmc#699

Closes Mirantis#50
@eromanova eromanova mentioned this pull request Dec 9, 2024
Merged
eromanova added a commit to eromanova/project-2a-docs that referenced this pull request Dec 9, 2024
@eromanova
Update BYO templates documentation
d754cc6 
Relates to Mirantis/hmc#615

Related hmc core changes: Mirantis/hmc#699

Closes Mirantis#50
Kshatrix
Kshatrix requested changes Dec 10, 2024
View reviewed changes
hack/templates.sh Show resolved Hide resolved
api/v1alpha1/templates_common.go Show resolved Hide resolved
internal/controller/release_controller.go Show resolved Hide resolved
@Kshatrix Kshatrix merged commit 4822e0f into Mirantis:main Dec 10, 2024
5 checks passed
@eromanova eromanova deleted the byo-simplify branch December 10, 2024 14:15
eromanova added a commit to Mirantis/project-2a-docs that referenced this pull request Dec 10, 2024
@eromanova
Update BYO templates documentation (#51)
1b35c5e 
Relates to Mirantis/hmc#615

Related hmc core changes: Mirantis/hmc#699

Closes #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kshatrix Kshatrix Kshatrix approved these changes

@zerospiel zerospiel zerospiel left review comments

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

Assignees

@eromanova eromanova

Labels
None yet
Projects
Project 2A
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify BYO Templates
3 participants
@eromanova @zerospiel @Kshatrix