-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundled beachhead services: cert-manager, external-secrets, velero, dex #797
Bundled beachhead services: cert-manager, external-secrets, velero, dex #797
Conversation
@wahabmk just to confirm, did you try this PR / tested the service templates? |
Yes I can see that the serviceTemplates have been installed:
|
Draft until testing deployments using added templates completed. Need to figure out whether services are usable with default values, or minimal required configuration. If the minimal required configuration is user-specific (Dex) or requires credentials (Velero) or requires CRDs (cert-manager) then it should be written in docs. |
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
fc1cfae
to
e8343b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Really nitpicking: CRs at the end of some files are missing (up to author to fix this)
And please squash commits before merging
Signed-off-by: Artem Bortnikov <[email protected]>
Added:
Fixes: #736 #737 #738 #739