Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled beachhead services: cert-manager, external-secrets, velero, dex #797

Merged

Conversation

BROngineer
Copy link
Contributor

@BROngineer BROngineer commented Dec 16, 2024

Added:

  • cert-manager v1.16.2 service template
  • external-secrets v0.11.0 service template
  • velero v8.1.0 service template
  • dex v0.19.1 service template

Fixes: #736 #737 #738 #739

@BROngineer BROngineer marked this pull request as ready for review December 16, 2024 14:53
@BROngineer BROngineer linked an issue Dec 16, 2024 that may be closed by this pull request
@DinaBelova DinaBelova requested a review from wahabmk December 17, 2024 14:59
wahabmk
wahabmk previously approved these changes Dec 18, 2024
@DinaBelova
Copy link
Collaborator

@wahabmk just to confirm, did you try this PR / tested the service templates?

@BROngineer BROngineer changed the title Bundled beachhead services: cert-manager, external-secrets Bundled beachhead services: cert-manager, external-secrets, velero, dex Dec 18, 2024
@wahabmk
Copy link
Contributor

wahabmk commented Dec 18, 2024

Yes I can see that the serviceTemplates have been installed:

➜  hmc git:(fc1cfae) ~ khmc get servicetemplate
NAME                      VALID
cert-manager-1-16-2       true
dex-0-19-1                true
external-secrets-0-11-0   true
ingress-nginx-4-11-0      true
ingress-nginx-4-11-3      true
kyverno-3-2-6             true
velero-8-1-0              true

wahabmk
wahabmk previously approved these changes Dec 18, 2024
@BROngineer BROngineer marked this pull request as draft December 18, 2024 19:15
@BROngineer
Copy link
Contributor Author

Draft until testing deployments using added templates completed. Need to figure out whether services are usable with default values, or minimal required configuration. If the minimal required configuration is user-specific (Dex) or requires credentials (Velero) or requires CRDs (cert-manager) then it should be written in docs.

@BROngineer BROngineer force-pushed the feat/epic-728-bundled-beachhead-services branch from fc1cfae to e8343b5 Compare December 18, 2024 20:20
@BROngineer BROngineer marked this pull request as ready for review December 18, 2024 20:31
a13x5
a13x5 previously approved these changes Dec 18, 2024
Copy link
Contributor

@a13x5 a13x5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Really nitpicking: CRs at the end of some files are missing (up to author to fix this)

And please squash commits before merging

Signed-off-by: Artem Bortnikov <[email protected]>
@BROngineer BROngineer dismissed stale reviews from a13x5 and wahabmk via 559d477 December 19, 2024 08:08
@BROngineer BROngineer merged commit ab78ddf into Mirantis:main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
6 participants