Add half panel display #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Unfortunately, I don't know about this error and therefore can't say exactly why it doesn't work without further details. But I am very happy to integrate your new display variant into the mod. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I really love this mod and I'm planning to use it with our upcoming server.
After playing with in our existing worlds, I wanted to make a version of the small display but with the thickness of the panel display, since space is usually limited inside trains. Whilst I am a developer, I don't have much experience with Minecraft mods. I believe I have set everything up correctly, using the existing code for the small and panel displays.
I worked on this inside IntelliJ IDEA and have it working through the fabric client through there, testing all of the orientations.
However, I am unable to build and create a jar file due to some errors such as
Cannot nest jars into none mod jar createrailwaysnavigator-0.5.2-beta-1.20.1-common.jar. I don't know enough about Minecraft modding to be able to sort this out. If you have any tips, or if you could build it and upload the jar it to this PR, that would be awesome.This display feels complete with the rest of the displays in the mod, especially since having the smaller font size and the 2:1 aspect ratio means you see more information. Of course, you have no obligation to include this into the mod, but I thought I might as well offer up the code back to you. Thank you for the time and effort you've put into the mod already.