Fix possible buffer overflow in ClpSimplexOther

[Mart-Bogdan]

I have found this as warning from GCC when was installing some packages from AUR.

There is possibility of buffer overflow, especially in this case:

sprintf(line, "Odd first line %s on file %s?", line, dataFile);

Because we are using content of array line inside template, and it can be 199 chars already.

[Mart-Bogdan]

P.S. I've noticed this warning when was trying to build https://github.com/google/or-tools

[Mizux]

To be sure, is it the backport of:
coin-or#279 and
coin-or#280

ps: thx for contributing to FOSS !

[Mart-Bogdan]

Yes, it's same fix applied to multiple reps.

I initially noticed warning about that when was building coin-or from google's repo. And your repo was used directly. So decided to post it here as well. IDK if upstream would accept patch soon.

[Mart-Bogdan]

and this line

<< line2 << CoinMessageEol;

was added, as same fix is in coin-or:master in upstream. (or somewhere else in upstream, I don't recall exactly, as it was some time ago)

using second variable. as "POSIX standard forbids strings to overlap."