-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-12026] Typing improvements #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0499bbe
to
0a04304
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #69 +/- ##
===========================================
+ Coverage 96.28% 96.37% +0.08%
===========================================
Files 48 48
Lines 1049 1075 +26
Branches 183 192 +9
===========================================
+ Hits 1010 1036 +26
Misses 23 23
Partials 16 16 ☔ View full report in Codecov by Sentry. |
0a04304
to
9e76705
Compare
9e76705
to
ae0b610
Compare
ae0b610
to
47ba2a4
Compare
47ba2a4
to
4fa538b
Compare
4fa538b
to
5a0fcab
Compare
5a0fcab
to
194533e
Compare
194533e
to
84d37ee
Compare
84d37ee
to
c487796
Compare
c487796
to
f22ebb0
Compare
maxim-lixakov
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This is because module lack
__all__
attribute, so linter thinks that all these classes are private, and should be imported from nested module. Added__all__
to fix that.@deprecated
decorator for old classes. This allows IDE to highlight classes like thisAlso updated old classes documentation to include deprecation notice
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)