Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-12026] Typing improvements #69

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[DOP-12026] Typing improvements #69

merged 1 commit into from
Dec 20, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Dec 19, 2023

Change Summary

  • Some linters (like Pylance in VS Code) complaining about imports from modules:
    изображение

This is because module lack __all__ attribute, so linter thinks that all these classes are private, and should be imported from nested module. Added __all__ to fix that.

  • Added @deprecated decorator for old classes. This allows IDE to highlight classes like this
    изображение

Also updated old classes documentation to include deprecation notice

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (602d04f) 96.28% compared to head (f22ebb0) 96.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #69      +/-   ##
===========================================
+ Coverage    96.28%   96.37%   +0.08%     
===========================================
  Files           48       48              
  Lines         1049     1075      +26     
  Branches       183      192       +9     
===========================================
+ Hits          1010     1036      +26     
  Misses          23       23              
  Partials        16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus self-assigned this Dec 19, 2023
@dolfinus dolfinus marked this pull request as ready for review December 19, 2023 13:20
@dolfinus dolfinus merged commit 23bc567 into develop Dec 20, 2023
13 checks passed
@dolfinus dolfinus deleted the feature/DOP-12026 branch December 20, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants