[DOP-15561] Cast DateTimeHWM to DateTime64 in Clickhouse #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
DateTime
precision in Clickhouse is only up to seconds. So using DateTimeHWM on column with higher precision, likeDateTime64
, can lead to reading the same value twice because fractional part of second is ignored.Cast Python
datetime
type toDateTime64(6)
in Clickhouse, keeping fractions of seconds. In case of using old Clickhouse versions (20.7 .. 21.0), users might have to updatehwm.expression
value, so this is a breaking change.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)