Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-23968] Add .get_exlude_packages() to SparkS3 and Kafka #341

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 18, 2025

Change Summary

SparkS3.get_packages() and Kafka.get_packages() return list of packages with compile dependency on hadoop client packages which are already a part of Spark/PySpark bundle. Also, SparkS3 uses spark-cloud package depending on lots of cloud clients, like GCP, Azure and so on, which are not required here.

Added .get_exclude_packages() method to both of these classes. Using spark.jar.excludes mechanism to tell Ivy2 that some transitive packages should be excluded.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (60aea9e) to head (7e9941a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #341      +/-   ##
===========================================
- Coverage    92.02%   92.00%   -0.03%     
===========================================
  Files          228      228              
  Lines         9867     9875       +8     
  Branches      1013     1013              
===========================================
+ Hits          9080     9085       +5     
- Misses         599      601       +2     
- Partials       188      189       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review February 18, 2025 12:58
@dolfinus dolfinus enabled auto-merge (rebase) February 18, 2025 15:07
@dolfinus dolfinus merged commit b9a19af into develop Feb 18, 2025
38 checks passed
@dolfinus dolfinus deleted the feature/DOP-23968 branch February 18, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants