Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-23982] Use tabs for complex code examples #344

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 18, 2025

Change Summary

Before:
https://onetl.readthedocs.io/en/latest/
image

After:
https://onetl--344.org.readthedocs.build/en/344/
image

Most of changes is just additional indentation in docstrings.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (35cd86e) to head (0aa55c7).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #344      +/-   ##
===========================================
- Coverage    92.48%   92.47%   -0.02%     
===========================================
  Files          228      228              
  Lines         9875     9875              
  Branches      1013     1013              
===========================================
- Hits          9133     9132       -1     
  Misses         556      556              
- Partials       186      187       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review February 19, 2025 10:46
@dolfinus dolfinus merged commit 10e221c into develop Feb 19, 2025
52 checks passed
@dolfinus dolfinus deleted the feature/DOP-23982 branch February 19, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants