Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22425] Run DB.check() on both driver and executor #346

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 19, 2025

Change Summary

Now all DB.check() methods ping database both from Spark driver and at least one Spark executor, to be sure that next operations (e.g. check+write) will not fail on executor side.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (7437eb3) to head (355a07b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
+ Coverage    92.47%   92.51%   +0.03%     
===========================================
  Files          228      228              
  Lines         9880     9908      +28     
  Branches      1013     1012       -1     
===========================================
+ Hits          9137     9166      +29     
  Misses         556      556              
+ Partials       187      186       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit 6845cda into develop Feb 21, 2025
44 checks passed
@dolfinus dolfinus deleted the feature/DOP-22425 branch February 21, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants