-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-22425] Run DB.check() on both driver and executor #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90048ea
to
11aeb10
Compare
11aeb10
to
a61122d
Compare
a61122d
to
4d06b98
Compare
4d06b98
to
733babb
Compare
733babb
to
9beb237
Compare
9beb237
to
3d611e9
Compare
3d611e9
to
18a298b
Compare
18a298b
to
9503801
Compare
9503801
to
3dfaf54
Compare
3dfaf54
to
1f10082
Compare
1f10082
to
70f3416
Compare
70f3416
to
89c9979
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #346 +/- ##
===========================================
+ Coverage 92.47% 92.51% +0.03%
===========================================
Files 228 228
Lines 9880 9908 +28
Branches 1013 1012 -1
===========================================
+ Hits 9137 9166 +29
Misses 556 556
+ Partials 187 186 -1 ☔ View full report in Codecov by Sentry. |
89c9979
to
babc1a9
Compare
babc1a9
to
af31efa
Compare
af31efa
to
30c332e
Compare
30c332e
to
ac2b8cc
Compare
ac2b8cc
to
355a07b
Compare
TiGrib
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Now all
DB.check()
methods ping database both from Spark driver and at least one Spark executor, to be sure that next operations (e.g. check+write) will not fail on executor side.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)