Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added rider categories feature #1995

Merged
merged 2 commits into from
Mar 3, 2025
Merged

feat: added rider categories feature #1995

merged 2 commits into from
Mar 3, 2025

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Feb 28, 2025

Summary:
Closes #1992
Added Rider Categories feature.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@emmambd emmambd requested a review from skalexch February 28, 2025 14:48
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 5468ee7
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (1 out of 1824 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

Dataset Notice Code
us-california-marin-transit-gtfs-71 missing_required_column
Dropped Errors (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (1 out of 1824 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

Dataset Notice Code
us-wisconsin-janesville-transit-system-gtfs-2239 missing_feed_contact_email_and_url
us-wisconsin-janesville-transit-system-gtfs-2239 missing_recommended_field

🛡️ Corruption Check

0 out of 1824 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.81 3.88 ⬆️+0.07
Median -- 1.34 1.42 ⬆️+0.08
Standard Deviation -- 11.90 11.86 ⬇️-0.04
Minimum in References Reports us-oregon-high-desert-point-gtfs-636 0.45 0.47 ⬆️+0.03
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 343.03 342.05 ⬇️-0.98
Minimum in Latest Reports us-oregon-high-desert-point-gtfs-636 0.45 0.47 ⬆️+0.03
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 343.03 342.05 ⬇️-0.98

⚠️ Warnings

The following dataset IDs are missing validation times either in reference or latest:
us-wisconsin-janesville-transit-system-gtfs-2239

📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 470.03 MiB 461.78 MiB ⬇️-8.25 MiB
Median -- 334.07 MiB 335.92 MiB ⬆️+1.85 MiB
Standard Deviation -- 785.20 MiB 759.80 MiB ⬇️-25.39 MiB
Minimum in References Reports ro-vrancea-consiliul-judetean-vrancea-gtfs-1984 38.00 MiB 68.95 MiB ⬆️+30.96 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 11.14 GiB 11.00 GiB ⬇️-142.56 MiB
Minimum in Latest Reports us-massachusetts-marthas-vineyard-transit-authority-gtfs-420 48.28 MiB 39.42 MiB ⬇️-8.86 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 11.14 GiB 11.00 GiB ⬇️-142.56 MiB

Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit f53dc74
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1824 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.76 3.88 ⬆️+0.12
Median -- 1.36 1.46 ⬆️+0.09
Standard Deviation -- 11.06 11.19 ⬆️+0.13
Minimum in References Reports us-massachusetts-massachusetts-area-express-max-gtfs-431 0.48 0.63 ⬆️+0.15
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 296.72 296.73 ⬆️+0.01
Minimum in Latest Reports ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 0.49 0.48 ⬇️-0.01
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 296.72 296.73 ⬆️+0.01
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 467.11 MiB 465.35 MiB ⬇️-1.76 MiB
Median -- 335.92 MiB 335.92 MiB ⬇️0 bytes
Standard Deviation -- 772.07 MiB 754.65 MiB ⬇️-17.42 MiB
Minimum in References Reports us-new-mexico-santa-fe-trails-gtfs-839 39.07 MiB 403.92 MiB ⬆️+364.85 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 11.37 GiB 11.07 GiB ⬇️-307.30 MiB
Minimum in Latest Reports us-south-dakota-sioux-area-metro-sam-gtfs-192 59.25 MiB 38.51 MiB ⬇️-20.74 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 11.37 GiB 11.07 GiB ⬇️-307.30 MiB

Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cka-y cka-y merged commit ecaa3f6 into master Mar 3, 2025
134 checks passed
@cka-y cka-y deleted the feat/1992 branch March 3, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Rider Categories feature
3 participants