Added dynamic grid option #128
Open
+197
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's looking pretty nice, I love the little scale indicator 👍 I've pushed a small change to the menu formatting, there's a slightly new (hopefully clearer) style I'm gradually converting them all to. I think we might need to add another slider for the target pixel size of each grid cell on screen, they do seem to be a bit on the small side on mobile compared to desktop. Or maybe just using the metric definition + default zoom as the reference. I'll test it out a bit more on different screens to see how it renders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grid modal was expanded, so it is possible to use dynamic grid (with scale dependent on the zoom levev). Second thing added was subgrid working regardless of dynamic or not dynamic grid setting.