-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 11/240408회의 api 개발 및 엔티티 수정 #13
The head ref may contain hidden characters: "feature_11/240408\uD68C\uC758-api-\uAC1C\uBC1C-\uBC0F-\uC5D4\uD2F0\uD2F0-\uC218\uC815"
Conversation
2. 내 채소 등록 api 수정
.map(diary -> AllDairy.of(diary, formatDate(diary.getCreatedDate()))) | ||
.toList(); | ||
} | ||
public static String formatDate(LocalDateTime date) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 메서드는 AllDairy 클래스가 온전히 책임을 질 기능으로 보이지 않아요. 다른 도메인, 파일에서 쓰일 여지가 충분한 것 같으니 Common과 같은 곳에 Util(예시) 클래스를 만들어서 관리하면 좋을 듯 합니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 도메인 util 패키지로 함수를 옮겼습닌다.
@AllArgsConstructor | ||
@Getter | ||
@Component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컴포넌트를 붙인 이유가 있을까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 이 dto를 의존성 주입하여 service에서 사용하려고 했습니다만 해당 클래스 proccessData()함수에 static을 붙여 수정했습니다.~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드에 코멘트 달았습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿 수고하셨습니다~
#️⃣연관된 이슈
📝작업 내용
Api 개발
스크린샷 (선택)
💬리뷰 요구사항(선택)