Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 34/rountine api 2 #35

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Feature 34/rountine api 2 #35

merged 6 commits into from
Jul 25, 2024

Conversation

Ryeolee
Copy link
Contributor

@Ryeolee Ryeolee commented Jul 25, 2024

  1. 수정 사항
  • Routine 엔티티 notify -> complete 변경
  • 루틴 추가 API
  1. 개발 사항
  • 루틴 수정 API
  • 루틴 삭제 API
  • 루틴 달력 월 별 체킹 조회 API
  • 루틴 일 별 채소들의 루틴 조회 API

@Ryeolee Ryeolee added the development 개발 label Jul 25, 2024
@Ryeolee Ryeolee self-assigned this Jul 25, 2024
@MinchoGreenT
Copy link
Contributor

수고하셨습니다. 몇가지 수정사항 제안해드립니다.

  1. 불필요한 들여쓰기 및 엔터.. 만 한번 쭉 훑으면서 제거해주시기 바랍니다.
  2. DataManager의 경우 날짜 포맷을 위한 클래스로 보이는데 컴포넌트화하거나 메서드를 스태틱으로 작성해서 객체를 생성하지 않고 다른 클래스에서 쓸 수 있도록 하는 방법이 좋을 것 같습니다.

@MinchoGreenT MinchoGreenT merged commit 8b47b41 into dev Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ryeolee Ryeolee

Labels
development 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryeolee @MinchoGreenT