Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] 채소의 일기 조회 시 조회 데이터 추가 (likeCount,commentCount, myLike ) #54

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

Ryeolee
Copy link
Contributor

@Ryeolee Ryeolee commented Jul 31, 2024

#️⃣연관된 이슈

ex) #52

📝작업 내용

채소의 모든 일기 조회 시 데이터 추가 / likeCount,commentCount, myLike

스크린샷 (선택)

없음

💬리뷰 요구사항(선택)

없음

@Ryeolee Ryeolee added the bug Something isn't working label Jul 31, 2024
@Ryeolee Ryeolee self-assigned this Jul 31, 2024
@Ryeolee Ryeolee linked an issue Jul 31, 2024 that may be closed by this pull request
@Ryeolee Ryeolee added development 개발 and removed bug Something isn't working labels Jul 31, 2024
Copy link
Contributor

@MinchoGreenT MinchoGreenT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

싱글 코멘트로 언급했지만, 대부분의 dto도 비슷한 것 같아 DTO 클래스명에 dto를 붙여 데이터통신 오브젝트라는 표시가 되도록 변경 요청드립니다!

@Ryeolee
Copy link
Contributor Author

Ryeolee commented Aug 1, 2024

전체적인 들여쓰기 및 dto는 리팩토링 시에 하려고 했습니다! 일단 AllDiary, DiaryAll 명이 제가 생각해도 어이가 없어섴ㅋ
DiaryAll -> SortedMyLikeDiary로 바꿨습니다!

@MinchoGreenT
Copy link
Contributor

수고하셨습니다.

@MinchoGreenT MinchoGreenT merged commit 3209b70 into dev Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 채소 일기
2 participants