Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] 메인화면 채소 프로필 조회 + 스텝 개수 추가 #65

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Ryeolee
Copy link
Contributor

@Ryeolee Ryeolee commented Aug 7, 2024

#️⃣연관된 이슈

ex) #64

📝작업 내용

메인화면 채소 프로필 조회 데이터 변경 / + 채소 스텝 수 추가

스크린샷 (선택)

없음

💬리뷰 요구사항(선택)

없음

@Ryeolee Ryeolee added the development 개발 label Aug 7, 2024
@Ryeolee Ryeolee requested a review from MinchoGreenT August 7, 2024 15:27
@Ryeolee Ryeolee self-assigned this Aug 7, 2024
@Ryeolee Ryeolee linked an issue Aug 7, 2024 that may be closed by this pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분에 대해서는 컨벤션이 없어서 작성은 자유지만, 현재 스텝수과 전체 스텝수를 나타내는 step과 stepCount의 변수명이 클라이언트 개발자가 볼 때 헷갈릴 수 있으니 명세서에 명확히 적는 것이 좋을 것 같네요 :)

Copy link
Contributor

@MinchoGreenT MinchoGreenT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@MinchoGreenT MinchoGreenT merged commit be5e7b3 into dev Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 메인 화면 위 컴포넌트
2 participants