Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add graphql operations for comments #176

Merged
merged 16 commits into from
Oct 15, 2023
Merged

feat: add graphql operations for comments #176

merged 16 commits into from
Oct 15, 2023

Conversation

Shurtu-gal
Copy link
Member

Solved or Linked Issues

Reference any and all issues solved and related to this pull request here. Mention if there are none.
Fixed #164

Description and Changes

Please describe your pull request with all changes made.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a work/topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the development (left side). Also you should start your branch off default branch and follow the branch naming guidelines.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation and mentioned the related issues (if appropriate)
  • I have added the appropriate labels, requested a review from a repository manager and assigned myself to this pull request.

Post merge checklist

@Shurtu-gal Shurtu-gal self-assigned this Jan 25, 2023
@Shurtu-gal Shurtu-gal added the enhancement New feature or request label Jan 25, 2023
@Shurtu-gal Shurtu-gal requested a review from 120EE0692 January 25, 2023 10:48
@Shurtu-gal Shurtu-gal added safe-for-checks This pull request is safe for actions and removed safe-for-checks This pull request is safe for actions labels Jan 25, 2023
@Shurtu-gal Shurtu-gal added the wip Work in Progress label Feb 2, 2023
@Shurtu-gal Shurtu-gal requested a review from 120EE0692 February 2, 2023 19:39
@Shurtu-gal Shurtu-gal removed the wip Work in Progress label Feb 3, 2023
120EE0692
120EE0692 requested changes Feb 4, 2023
View reviewed changes
server/schema/comment/comment.datasources.js Outdated Show resolved Hide resolved
server/schema/comment/comment.datasources.js Outdated Show resolved Hide resolved
server/schema/comment/comment.datasources.js Outdated Show resolved Hide resolved
120EE0692
120EE0692 requested changes Feb 4, 2023
View reviewed changes
server/schema/comment/comment.query.js Show resolved Hide resolved
server/schema/comment/comment.query.js Outdated Show resolved Hide resolved
server/schema/comment/comment.resolver.js Outdated Show resolved Hide resolved
server/schema/comment/comment.resolver.js Outdated Show resolved Hide resolved
@Shurtu-gal Shurtu-gal requested a review from 120EE0692 February 4, 2023 10:13
120EE0692
120EE0692 previously approved these changes Mar 1, 2023
View reviewed changes
@120EE0692 120EE0692 requested a review from rutajdash March 1, 2023 08:25
@Shurtu-gal Shurtu-gal requested a review from 120EE0692 March 1, 2023 09:37
@120EE0692
Copy link
Member

Role Name comment.read.public comment.read.unapproved comment.write.new comment.write.approved comment.write.self comment.write.delete comment.approve.all
comment.basic true false true false true false false
comment.verified true false true true true false false
comment.admin true true true true true false true
comment.superadmin true true true true true true true

@Shurtu-gal can you please verify this permission check are implemented or not.

@rutajdash
Copy link
Member

@120EE0692 close this PR if inactive

@Shurtu-gal
Copy link
Member Author

Role Name comment.read.public comment.read.unapproved comment.write.new comment.write.approved comment.write.self comment.write.delete comment.approve.all
comment.basic true false true false true false false
comment.verified true false true true true false false
comment.admin true true true true true false true
comment.superadmin true true true true true true true
@Shurtu-gal can you please verify this permission check are implemented or not.

I will do it by EOD today. I was out for some days

@Shurtu-gal
Copy link
Member Author

@120EE0692 Kindly Review this.

120EE0692
120EE0692 previously approved these changes Sep 26, 2023
View reviewed changes
@120EE0692
Copy link
Member

@Shurtu-gal please rebase this with the main branch.

@Shurtu-gal
Copy link
Member Author

@120EE0692 Done

@120EE0692 120EE0692 merged commit 8fd2962 into Monday-Morning:main Oct 15, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@120EE0692 120EE0692 120EE0692 approved these changes

@DesignrKnight DesignrKnight Awaiting requested review from DesignrKnight

@rutajdash rutajdash Awaiting requested review from rutajdash

Assignees

@Shurtu-gal Shurtu-gal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add graphql operations for comments
4 participants
@Shurtu-gal @120EE0692 @rutajdash @DesignrKnight