-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Matter plugin #3
Conversation
f37b3a6
to
0e99362
Compare
0e99362
to
c944a99
Compare
9b1d795
to
68f1b73
Compare
tests/spread/plugins/craft-parts/build-and-run-hello/matter-hello/snap/snapcraft.yaml
Outdated
Show resolved
Hide resolved
Could you please review @farshidtz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please see my comments.
Have you also tried running the spread tests?
tests/spread/plugins/craft-parts/build-and-run-hello/matter-hello/snap/snapcraft.yaml
Outdated
Show resolved
Hide resolved
tests/spread/plugins/craft-parts/build-and-run-hello/matter-hello/snap/snapcraft.yaml
Outdated
Show resolved
Hide resolved
tests/spread/plugins/craft-parts/build-and-run-hello/matter-hello/app/main.cpp
Outdated
Show resolved
Hide resolved
tests/spread/plugins/craft-parts/build-and-run-hello/matter-hello/app/main.cpp
Outdated
Show resolved
Hide resolved
tests/spread/plugins/craft-parts/build-and-run-hello/matter-hello/snap/snapcraft.yaml
Outdated
Show resolved
Hide resolved
As mentioned in this PR description, the spread test has not been executed on the local machine. The hello world snap, using the Matter plugin, has been manually tested to verify that the output is equal to 'hello world.' The spread test is integrated into the GitHub Action process. |
tests/spread/plugins/craft-parts/build-and-run-hello/matter-hello/snap/snapcraft.yaml
Outdated
Show resolved
Hide resolved
The linter check error is unrelated to this PR and has already been fixed upstream. It will be solved once this branch has been rebased on the upstream main. |
6b8472e
to
4751257
Compare
- use Git shallow checkout - separate matter SDK part
cce2af1
to
2a1cfe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find my latest round of review addressing the changes and some of the original plugin code.
This PR
add spread test to build a hello world matter snapTesting
Unit test
setting up a development environment, then run only the unit tests for the plugins:
tox test
Spread test for plugins integration (with matter-lighting snap)
Please note this spread test has not been executed on the local machine. The matter-lighting app, based on the Matter plugin, can be built and manually tested by runing: