Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Adds a host of new makeshift items #848

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

KoboldCommando
Copy link

About The Pull Request

This is a port of yogstation13/Yogstation#13374 and yogstation13/Yogstation#15141

It adds

  • craftable makeshift tools, they're slow and break but function
  • craftable makeshift silencers for guns
  • craftable makeshift pistol
  • craftable makeshift lasrifle
  • craftable makeshift 10mm magazines
  • craftable pipe bombs
  • craftable knife boxing gloves
  • craftable makeshift emag

There are some differences from the yog versions. We can emag supply consoles since we don't have null crates, but the emag is much more likely to set you on fire, and it starts with 0 charges necessitating a source of uranium. Anyone can craft these items since we generally don't balance through restricting recipes, and these items are risky and highly illegal.

Why It's Good For The Game

First and foremost this should make blood brothers a LOT more interesting since you can scavenge together some illegal items. It also may help in desperation scenarios, and just create more room for shenanigans in general.

But free emag!!

Take a close look before judging it. It requires a tcomms component to build, uranium to run, is slow and likely to burn you. I think in general trying to make and use it is a bad idea(tm), which is of course why people will do it and have fun with it.

Changelog

🆑 nmajask and TheRyeGuyWhoWillNowDie ported by KoboldCommando
add: Added many new makeshift variants of existing items, check out the crafting menu!
/:cl:

@dwasint
Copy link
Collaborator

dwasint commented Dec 8, 2022

the emag is scary for the simple reason it will become a rush item for chemists to get those op emagged chems regardless of the risk

@KoboldCommando
Copy link
Author

the emag is scary for the simple reason it will become a rush item for chemists to get those op emagged chems regardless of the risk

I can agree with this. Though it does have a 40% chance of doing nothing and a 20% chance of lighting you on fire. And it requires advanced resources. Can you think of anything else to make people hesitate? Maybe a worse burn, or even a small chance to outright explode?

@Oricana-16
Copy link

My suggestion is full explosion instead of just fire, and swap and change it to more like 50% explode, 20% nothing, 30% works. Might even wanna split the 30% into like 15% emps the thing, 15% it emags, just to make it even less likely to work how they want it, while also not punishing them Super hard.

It's very powerful, because if the chance is high enough some rng god will just use it to run into whatever high access area they need or order and call the escape shuttle, or emag beepsky etc etc, and just not use it after that.

@dwasint
Copy link
Collaborator

dwasint commented Dec 8, 2022

the emag is scary for the simple reason it will become a rush item for chemists to get those op emagged chems regardless of the risk

I can agree with this. Though it does have a 40% chance of doing nothing and a 20% chance of lighting you on fire. And it requires advanced resources. Can you think of anything else to make people hesitate? Maybe a worse burn, or even a small chance to outright explode?

add a variable to the circuit board itself add a chance for it to roll something that just fucks the board up, like removing some chemicals and stopping it from being emagged again

@KoboldCommando
Copy link
Author

I changed the emag. It now has a 50% chance to do nothing. A 10% chance to light you on fire. And a 5% chance to explode with the strength of a PDA bomb, destroying whatever you're emagging, and hurting and deafening you. It's got a 35% chance of success in the end.

Try it for yourself! The several second use bar combined with the chance to explode is delightfully horrifying!

Copy link
Member

@nednaZ nednaZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few balance concerns, but should be overall fun

code/datums/components/crafting/makeshift.dm Outdated Show resolved Hide resolved
code/datums/components/crafting/makeshift.dm Outdated Show resolved Hide resolved
code/datums/components/crafting/makeshift.dm Outdated Show resolved Hide resolved
Comment on lines 30 to 37
/datum/crafting_recipe/makeshiftmagazine
name = "Makeshift Pistol Magazine (10mm)"
result = /obj/item/ammo_box/magazine/m10mm/makeshift
reqs = list(/obj/item/stack/sheet/iron = 2,
/obj/item/stack/tape = 2)
time = 12 SECONDS
category = CAT_WEAPONRY
subcategory = CAT_AMMO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't let them craft magazines, single-shot pistols

code/datums/components/crafting/makeshift.dm Outdated Show resolved Hide resolved
Comment on lines 28 to 33
/obj/item/ammo_box/magazine/m10mm/makeshift
name = "makeshift pistol magazine (10mm)"
desc = "A hastily made gun magazine that can only store 4 bullets."
icon_state = "9x19pM"
max_ammo = 4
start_empty = TRUE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if I make the makeshift pistol single-shot, a makeshift magazine would be handy. You can sometimes find guns with no magazine and it's difficult to render them usable.

@@ -85,3 +85,15 @@
to_chat(user, "<span class='notice'>..and falls into view. Whew, that was a close one.</span>")
user.dropItemToGround(src)

/obj/item/gun/ballistic/automatic/pistol/makeshift
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like it to be designed as a single-shot pistol, similar to a FP-45 Liberator pistol.
Should need to rack the slide, load a new round, rack again

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bit of a pain, but done!

code/modules/projectiles/guns/energy/laser.dm Outdated Show resolved Hide resolved
Comment on lines 179 to 180
/obj/item/projectile/beam/laser/buckshot
damage = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra addition?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

build_type = BIOGENERATOR
materials = list(/datum/material/biomass = 50)
build_path = /obj/item/stack/tape
category = list("initial","Organic Materials")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Higher tier rather than baseline?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like requiring research would kind of defeat the purpose of makeshift shoddy items.

@nednaZ nednaZ added Port A port of a feature from another codebase Feature adds something new to the game labels Dec 14, 2022
@KoboldCommando
Copy link
Author

There's a big question left in this PR, because I did it in a non-modular manner thinking that we had abandoned the modular folder. Would I need to adjust ALL the files, items and sprites to go into the modular folder? That would basically be re-doing the entire thing from scratch.

@KoboldCommando
Copy link
Author

I finally got back to this and got it modularizified, it's ready for another look

Copy link
Collaborator

@dwasint dwasint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still think the emag will need to have extensive testing as thats the main concern here, outside of that i really like these they fit with the locker mech we have that isn't used to much lol

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature adds something new to the game Port A port of a feature from another codebase sound sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants