Skip to content

Commit

Permalink
[PORT] Adds a unit test for typepaths that are required to be mapped …
Browse files Browse the repository at this point in the history
…onto each station map (#2346)

* [MDB Ignore] Adds a unit test for typepaths that are required to be mapped onto each station map (#74985)

Inspired by #74967 and #68459 , and the fact that Tramstation regresses
very often -

Adds a unit test, `required_map_items`, which ensures that certain
typepaths which should definitely be mapped onto every map is mapped
onto every map

It can also be used to ensure that items which should not be mapped in
multiple times are not, among other things.

I included a few examples -
- Min 1, max inf of each head of staff stamps
- Min 1, max 1 departmental order consoles
- Min 1, max inf comms console
- Min 1, max 1 Pun Pun
- Min 1, max 1 Poly
- Min 1, max 1 Ian

If, in the future, a mapper decides they (for some reason) do not want a
certain previously-required item on their map, the test can be adjusted
such that it allows excluding or something, but currently it should be
for items which require conscious thought about.

I attempted to make this a linter before realizing two things
1. Someone might make a spawner which spawns the items, or they might
get placed in a locker, in any case this accounts for everything on init
2. Linters run on every map, non-station maps included

So I went with a test

Why is it always the CMO stamp?

Not necessary (unless I find a map missing something, then this will be
updated)

* byeah

* bwoh

* fixup

* Bweh

* Add CMO stamp to Tram

* Add holomaps

* AAAAAAAAAAAAAAAAAAAA

* guh

* me when

* Update stamps on Blueshift, shoddily map missing stuff into Kilo

* Directional ATMs, re-add holomaps

* Whoopsie daisy

* Wait shit

* Add a generous amount of holomaps to blueshift

---------

Co-authored-by: MrMelbert <[email protected]>
  • Loading branch information
Absolucy and MrMelbert authored Jul 1, 2024
1 parent 5bb3785 commit 0212e79
Show file tree
Hide file tree
Showing 68 changed files with 10,022 additions and 9,701 deletions.
2 changes: 1 addition & 1 deletion _maps/RandomRuins/SpaceRuins/hilbertresearchfacility.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -1187,7 +1187,7 @@
"BL" = (
/obj/structure/table/wood,
/obj/item/folder/white,
/obj/item/stamp/rd,
/obj/item/stamp/head/rd,
/turf/open/floor/iron/grimy,
/area/ruin/space/has_grav/powered/hilbertresearchfacility)
"BM" = (
Expand Down
2 changes: 1 addition & 1 deletion _maps/RandomRuins/SpaceRuins/waystation.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
pixel_x = 7;
pixel_y = 4
},
/obj/item/stamp/qm{
/obj/item/stamp/head/qm{
pixel_x = 7;
pixel_y = -2
},
Expand Down
2 changes: 1 addition & 1 deletion _maps/RandomZLevels/moonoutpost19.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -2904,7 +2904,7 @@
/obj/structure/window/reinforced/spawner/directional/north,
/obj/structure/window/reinforced/spawner/directional/west,
/obj/item/folder/white,
/obj/item/stamp/rd{
/obj/item/stamp/head/rd{
pixel_x = 3;
pixel_y = -2
},
Expand Down
4 changes: 2 additions & 2 deletions _maps/RandomZLevels/undergroundoutpost45.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -5519,7 +5519,7 @@
/obj/structure/window/reinforced/spawner/directional/north,
/obj/structure/window/reinforced/spawner/directional/west,
/obj/item/folder/white,
/obj/item/stamp/rd{
/obj/item/stamp/head/rd{
pixel_x = 3;
pixel_y = -2
},
Expand Down Expand Up @@ -10161,7 +10161,7 @@
/obj/item/clothing/glasses/meson{
pixel_y = 4
},
/obj/item/stamp/ce,
/obj/item/stamp/head/ce,
/obj/effect/turf_decal/tile/neutral/fourcorners,
/turf/open/floor/iron{
heat_capacity = 1e+006
Expand Down
Loading

0 comments on commit 0212e79

Please sign in to comment.