Skip to content

Commit

Permalink
Shuts up a bunch of RegisterSignal runtimes
Browse files Browse the repository at this point in the history
  • Loading branch information
Absolucy committed Nov 30, 2024
1 parent 592f949 commit cb97226
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
9 changes: 5 additions & 4 deletions code/datums/elements/climbable.dm
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@
if(climb_stun)
src.climb_stun = climb_stun

RegisterSignal(target, COMSIG_ATOM_ATTACK_HAND, PROC_REF(attack_hand))
RegisterSignal(target, COMSIG_ATOM_EXAMINE, PROC_REF(on_examine))
RegisterSignal(target, COMSIG_MOUSEDROPPED_ONTO, PROC_REF(mousedrop_receive))
RegisterSignal(target, COMSIG_ATOM_BUMPED, PROC_REF(try_speedrun))
// remove the `override = TRUE` whenever we actually fix this shit
RegisterSignal(target, COMSIG_ATOM_ATTACK_HAND, PROC_REF(attack_hand), override = TRUE)
RegisterSignal(target, COMSIG_ATOM_EXAMINE, PROC_REF(on_examine), override = TRUE)
RegisterSignal(target, COMSIG_MOUSEDROPPED_ONTO, PROC_REF(mousedrop_receive), override = TRUE)
RegisterSignal(target, COMSIG_ATOM_BUMPED, PROC_REF(try_speedrun), override = TRUE)
ADD_TRAIT(target, TRAIT_CLIMBABLE, ELEMENT_TRAIT(type))

/datum/element/climbable/Detach(datum/target)
Expand Down
2 changes: 1 addition & 1 deletion code/datums/elements/elevation.dm
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
src.pixel_shift = pixel_shift

if(ismovable(target))
RegisterSignal(target, COMSIG_MOVABLE_MOVED, PROC_REF(on_moved))
RegisterSignal(target, COMSIG_MOVABLE_MOVED, PROC_REF(on_moved), override = TRUE) // temporary workaround. probably.

var/atom/atom_target = target
if(isturf(atom_target.loc))
Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/_machinery.dm
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@
return
update_current_power_usage()
power_change()
RegisterSignal(area_to_register, COMSIG_AREA_POWER_CHANGE, PROC_REF(power_change))
RegisterSignal(area_to_register, COMSIG_AREA_POWER_CHANGE, PROC_REF(power_change), override = TRUE) // we can re-enter the same area due to shuttles and shit

/obj/machinery/proc/on_exit_area(datum/source, area/area_to_unregister)
SIGNAL_HANDLER
Expand Down

0 comments on commit cb97226

Please sign in to comment.