Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
dwasint committed Sep 21, 2024
1 parent 34d1c30 commit eeb9c6f
Show file tree
Hide file tree
Showing 11 changed files with 27 additions and 23 deletions.
1 change: 0 additions & 1 deletion code/__HELPERS/mobs.dm
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@

//For now we will always return none for tail_human and ears. | "For now" he says.
return(list(
"ethcolor" = GLOB.color_list_ethereal[pick(GLOB.color_list_ethereal)],
"tail_cat" = "None",
"tail_lizard" = "Smooth",
"wings" = "None",
Expand Down
6 changes: 0 additions & 6 deletions code/datums/dna.dm
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,6 @@ GLOBAL_LIST_INIT(total_uf_len_by_block, populate_total_uf_len_by_block())
. = ""
var/list/L = new /list(DNA_FEATURE_BLOCKS)

if(features["ethcolor"])
L[DNA_ETHEREAL_COLOR_BLOCK] = sanitize_hexcolor(features["ethcolor"], include_crunch = FALSE)
if(features["body_markings"])
L[DNA_LIZARD_MARKINGS_BLOCK] = construct_block(GLOB.body_markings_list.Find(features["body_markings"]), GLOB.body_markings_list.len)
if(features["tail_cat"])
Expand Down Expand Up @@ -338,8 +336,6 @@ GLOBAL_LIST_INIT(total_uf_len_by_block, populate_total_uf_len_by_block())
if(!ishuman(holder))
CRASH("Non-human mobs shouldn't have DNA")
switch(blocknumber)
if(DNA_ETHEREAL_COLOR_BLOCK)
set_uni_feature_block(blocknumber, sanitize_hexcolor(features["ethcolor"], include_crunch = FALSE))
if(DNA_LIZARD_MARKINGS_BLOCK)
set_uni_feature_block(blocknumber, construct_block(GLOB.body_markings_list.Find(features["body_markings"]), GLOB.body_markings_list.len))
if(DNA_TAIL_BLOCK)
Expand Down Expand Up @@ -618,8 +614,6 @@ GLOBAL_LIST_INIT(total_uf_len_by_block, populate_total_uf_len_by_block())
else
hairstyle = GLOB.hairstyles_list[deconstruct_block(get_uni_identity_block(structure, DNA_HAIRSTYLE_BLOCK), GLOB.hairstyles_list.len)]
var/features = dna.unique_features
if(dna.features["ethcolor"])
dna.features["ethcolor"] = sanitize_hexcolor(get_uni_feature_block(features, DNA_ETHEREAL_COLOR_BLOCK))
if(dna.features["body_markings"])
dna.features["body_markings"] = GLOB.body_markings_list[deconstruct_block(get_uni_feature_block(features, DNA_LIZARD_MARKINGS_BLOCK), GLOB.body_markings_list.len)]
if(dna.features["snout"])
Expand Down
3 changes: 2 additions & 1 deletion code/modules/antagonists/brother/brother.dm
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,9 @@
/datum/antagonist/brother/get_base_preview_icon()
var/mob/living/carbon/human/dummy/consistent/brother1 = new
var/mob/living/carbon/human/dummy/consistent/brother2 = new
var/datum/color_palette/generic_colors/located = brother1.dna.color_palettes[/datum/color_palette/generic_colors]

brother1.dna.features["ethcolor"] = GLOB.color_list_ethereal["Faint Red"]
located.ethereal_color = GLOB.color_list_ethereal["Faint Red"]
brother1.set_species(/datum/species/ethereal)

brother2.dna.features["moth_antennae"] = "Plain"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@
return values

/datum/preference/choiced/ethereal_color/apply_to_human(mob/living/carbon/human/target, value)
target.dna.features["ethcolor"] = GLOB.color_list_ethereal[value]
return
2 changes: 1 addition & 1 deletion code/modules/mob/living/carbon/human/dummy.dm
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ INITIALIZE_IMMEDIATE(/mob/living/carbon/human/dummy)
target.dna.initialize_dna(/datum/blood_type/crew/human/o_plus, skip_index = TRUE)
target.dna.features["body_markings"] = "None"
target.dna.features["ears"] = "None"
target.dna.features["ethcolor"] = COLOR_WHITE
target.dna.features["frills"] = "None"
target.dna.features["horns"] = "None"
target.dna.features["moth_antennae"] = "Plain"
Expand Down Expand Up @@ -128,6 +127,7 @@ INITIALIZE_IMMEDIATE(/mob/living/carbon/human/dummy)
var/datum/color_palette/generic_colors/palette = target.dna.color_palettes[/datum/color_palette/generic_colors]
palette.mutant_color = COLOR_VIBRANT_LIME
palette.mutant_color_secondary = COLOR_VIBRANT_LIME
palette.ethereal_color = COLOR_WHITE

/// Provides a dummy that is consistently bald, white, naked, etc.
/mob/living/carbon/human/dummy/consistent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -274,5 +274,6 @@

/datum/species/ethereal/lustrous/on_species_gain(mob/living/carbon/new_lustrous, datum/species/old_species, pref_load)
..()
default_color = new_lustrous.dna.features["ethcolor"]
new_lustrous.dna.features["ethcolor"] = GLOB.color_list_lustrous[pick(GLOB.color_list_lustrous)] //Picks one of 5 lustrous-specific colors.
var/datum/color_palette/generic_colors/palette = new_lustrous.dna.color_palettes[/datum/color_palette/generic_colors]
default_color = palette.ethereal_color
palette.ethereal_color = GLOB.color_list_lustrous[pick(GLOB.color_list_lustrous)] //Picks one of 5 lustrous-specific colors.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
unarmed_attack_sound = 'sound/weapons/etherealhit.ogg'
unarmed_miss_sound = 'sound/weapons/etherealmiss.ogg'
palette = /datum/color_palette/generic_colors
palette_key = MUTANT_COLOR
palette_key = "ethereal_color"

/obj/item/bodypart/head/ethereal/update_limb(dropping_limb, is_creating)
. = ..()
Expand All @@ -23,7 +23,7 @@
is_dimorphic = FALSE
dmg_overlay_type = null
palette = /datum/color_palette/generic_colors
palette_key = MUTANT_COLOR
palette_key = "ethereal_color"

/obj/item/bodypart/chest/ethereal/update_limb(dropping_limb, is_creating)
. = ..()
Expand All @@ -41,7 +41,7 @@
unarmed_attack_sound = 'sound/weapons/etherealhit.ogg'
unarmed_miss_sound = 'sound/weapons/etherealmiss.ogg'
palette = /datum/color_palette/generic_colors
palette_key = MUTANT_COLOR
palette_key = "ethereal_color"

/obj/item/bodypart/arm/left/ethereal/update_limb(dropping_limb, is_creating)
. = ..()
Expand All @@ -59,7 +59,7 @@
unarmed_attack_sound = 'sound/weapons/etherealhit.ogg'
unarmed_miss_sound = 'sound/weapons/etherealmiss.ogg'
palette = /datum/color_palette/generic_colors
palette_key = MUTANT_COLOR
palette_key = "ethereal_color"

/obj/item/bodypart/arm/right/ethereal/update_limb(dropping_limb, is_creating)
. = ..()
Expand All @@ -77,7 +77,7 @@
unarmed_attack_sound = 'sound/weapons/etherealhit.ogg'
unarmed_miss_sound = 'sound/weapons/etherealmiss.ogg'
palette = /datum/color_palette/generic_colors
palette_key = MUTANT_COLOR
palette_key = "ethereal_color"

/obj/item/bodypart/leg/left/ethereal/update_limb(dropping_limb, is_creating)
. = ..()
Expand All @@ -94,7 +94,7 @@
unarmed_attack_sound = 'sound/weapons/etherealhit.ogg'
unarmed_miss_sound = 'sound/weapons/etherealmiss.ogg'
palette = /datum/color_palette/generic_colors
palette_key = MUTANT_COLOR
palette_key = "ethereal_color"

/obj/item/bodypart/leg/right/ethereal/update_limb(dropping_limb, is_creating)
. = ..()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
if(!ishuman(new_ethereal))
return
var/mob/living/carbon/human/ethereal = new_ethereal
default_color = ethereal.dna.features["ethcolor"]
var/datum/color_palette/generic_colors/palette = ethereal.dna.color_palettes[/datum/color_palette/generic_colors]
default_color = palette.ethereal_color
r1 = GETREDPART(default_color)
g1 = GETGREENPART(default_color)
b1 = GETBLUEPART(default_color)
Expand Down Expand Up @@ -104,14 +105,16 @@
return randname

/datum/species/ethereal/randomize_features(mob/living/carbon/human/human_mob)
human_mob.dna.features["ethcolor"] = GLOB.color_list_ethereal[pick(GLOB.color_list_ethereal)]
var/datum/color_palette/generic_colors/palette = human_mob.dna.color_palettes[/datum/color_palette/generic_colors]
palette.ethereal_color = GLOB.color_list_ethereal[pick(GLOB.color_list_ethereal)]

/datum/species/ethereal/spec_updatehealth(mob/living/carbon/human/ethereal)
. = ..()
var/datum/color_palette/generic_colors/palette = ethereal.dna.color_palettes[/datum/color_palette/generic_colors]
if(!ethereal_light)
return
if(default_color != ethereal.dna.features["ethcolor"])
var/new_color = ethereal.dna.features["ethcolor"]
if(default_color != palette.ethereal_color)
var/new_color = palette.ethereal_color
r1 = GETREDPART(new_color)
g1 = GETGREENPART(new_color)
b1 = GETBLUEPART(new_color)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
bodypart_overlay = /datum/bodypart_overlay/mutant/ethereal_horns

/datum/bodypart_overlay/mutant/ethereal_horns
layers = EXTERNAL_FRONT|EXTERNAL_BEHIND
layers = EXTERNAL_FRONT|EXTERNAL_ADJACENT
feature_key = "ethereal_horns"
palette = /datum/color_palette/generic_colors
palette_key = "ethereal_color"

/datum/bodypart_overlay/mutant/ethereal_horns/get_global_feature_list()
return GLOB.ethereal_horns_list
Expand All @@ -38,6 +40,8 @@
/datum/bodypart_overlay/mutant/tail/ethereal
layers = EXTERNAL_FRONT|EXTERNAL_BEHIND
feature_key = "ethereal_tail"
palette = /datum/color_palette/generic_colors
palette_key = "ethereal_color"

/datum/bodypart_overlay/mutant/tail/ethereal/get_global_feature_list()
return GLOB.ethereal_tail_list
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
var/mutant_color
var/mutant_color_secondary
var/fur_color
var/ethereal_color

/datum/color_palette/generic_colors/apply_prefs(datum/preferences/incoming)
hair_color = incoming.read_preference(/datum/preference/color/hair_color)
mutant_color = incoming.read_preference(/datum/preference/color/mutant_color)
mutant_color_secondary = incoming.read_preference(/datum/preference/color/mutant_color_secondary)
fur_color = incoming.read_preference(/datum/preference/color/fur_color)
ethereal_color = GLOB.color_list_ethereal[incoming.read_preference(/datum/preference/choiced/ethereal_color)]
Binary file modified monkestation/icons/mob/species/ethereal/ethereal_horns.dmi
Binary file not shown.

0 comments on commit eeb9c6f

Please sign in to comment.