Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oozeling eyes do not regenerate with the rest of the head #2777

Closed
MonkestationIssueBot opened this issue Jul 30, 2024 · 6 comments · Fixed by #4343
Closed

Oozeling eyes do not regenerate with the rest of the head #2777

MonkestationIssueBot opened this issue Jul 30, 2024 · 6 comments · Fixed by #4343

Comments

@MonkestationIssueBot
Copy link

MonkestationIssueBot commented Jul 30, 2024

Reporting client info: Client Information:
BYOND:515.1639
Key:eddywall

Round ID:

6088

Testmerges:

Reproduction:

when your head is chopped off as an oozeling, you go blind since your eyes are gone. If you regenerate your head, you are still blind. The eyes themselves do not come back. Found by leaping with tackle gloves into a vending machinea nd getting my head decapitated, then trying to regen my head.

@DexeeXI
Copy link
Collaborator

DexeeXI commented Sep 4, 2024

@ThePooba needs repro

@Coll6
Copy link
Contributor

Coll6 commented Dec 19, 2024

@ThePooba needs repro
@DexeeXI
@ThePooba
Okay I know the reason for this. It is because head regeneration while a limb doesn't doesnt heal blindness which is applied when the head is removed. This commit in my big oozling PR should address it. d0e6163

@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 19, 2024

@Coll6 are you able to atomize that fix from #4343 ? Or, if you can provide deeper documentation on #4343 and link it to issues that it will fix, that might push it up.

@Coll6
Copy link
Contributor

Coll6 commented Dec 19, 2024

@Coll6 are you able to atomize that fix from #4343 ? Or, if you can provide deeper documentation on #4343 and link it to issues that it will fix, that might push it up.

I am not entirely sure what you mean by deeper documentation but my code I believe in that commit gives an idea of why it is happening and what to do to fix it. Beheading is doing something similar to
new_body.become_blind(NO_EYES)
the regeneration if the head was missing doesnt cure blinding but adding H.cure_blind(NO_EYES) restores sight. If you can provide more clarification, I will do what is requested. This PR is addressing a lot of bugs.

Coll6 referenced this issue Dec 19, 2024
-Implants that go into the chest now drop unpon revival
-Cavity implant objects now drop unpon revival
-Fixes visual bugs caused by reviving a oozling core
-Minor grammar fixes
@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 19, 2024

Link your PR to issues. Using specific terminology of "Fixes #2777" will automatically have it added to the PR's listing.

@Coll6
Copy link
Contributor

Coll6 commented Dec 19, 2024

Okay believe I have done so. Have several more bug fixes to go before pushing it to a full request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants