Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oozling qol fixes #4343

Merged
merged 39 commits into from
Dec 29, 2024
Merged

Oozling qol fixes #4343

merged 39 commits into from
Dec 29, 2024

Conversation

Coll6
Copy link
Contributor

@Coll6 Coll6 commented Nov 23, 2024

About The Pull Request

This pull request introduces a range of quality-of-life improvements, bug fixes, and enhancements specifically designed for the Oozling species. These changes aim to refine their mechanics, resolve bugs, and enhance the overall gameplay experience for Oozling players. Key adjustments include improvements to their interactions with water and plasma, restoring their unique abilities, and aligning their mechanics more closely with player expectations while maintaining their distinct traits.

Why It's Good For The Game

It also restores previously lost abilities and reactivates dormant wetness code, making water a more dangerous and impactful element for Oozlings as originally intended. Furthermore, smaller visual bugs caused by revival have been fixed, and groundwork has been laid for potentially allowing Oozling heads to be decapitated in combat, similar to other limbs. These changes collectively ensure a more balanced, functional, and engaging experience for Oozling players and the game as a whole.

Changelog

🆑Siro
fix: Some Quirks that give unique items or random rolled effects will be transferred between bodies. Fixes #2247 and Fixes #2354
fix: Oozling ability status effects like Slime Cleaning and Hydrophobia slow down will be removed upon ability loss.
fix: Oozling core no longer broadcasts GPS after being crushed.
fix: Dnr Oozling sacrifice runtime due to brainmob not having a last_mind field Fixes #4219
fix: Resolved issue where Oozling cores could prevent core item ejection during core destruction.
fix: Head regeneration fixes no eyes blindness. Fixes #2777
fix: Gibbing deaths (which is a bigger list for oozlings) will now correctly delete the Oozling core rather than dropping one with no soul attached. Fixes #2540 and similar instances. Few rare cases exist like emagged Recyclers.
add: Oozlings now scream and have the jitter status applied to them when nugget revived. Similar to human revival.
add: Foreign objects, such as organ implants and features, are now pulled into the core instead of being deleted outright. Fixes #3665
add: Ooozlings now like toxic foods. Slime Jelly rolls anyone?
balance: Restored the wetness system: 1 blood randomly above 1 stack. Above 5 lose 2 blood constantly
code: Ensured items are handled and moved into the core first before other object-move mechanics can take place. Fixes unintended duplication and deletion bugs (e.g., chasms). Fixes #4107
fix: Addressed revival visual/HUD/gameplay bugs, by properly removing the limbs on nugget revival. Fixes #2485
balance: Re-added healing, reduced from 2 burn 2 brute to 2.5 shared to both. Must stay warm and Hydrophobia off.
add: Added filters to Oozling core storage to prevent certain items (e.g., Nuclear Authentication Disk) from being stored. Fixes issues with protected items.
/:cl:

Coll6 added 13 commits November 18, 2024 10:20
-Restores dormant Oozling wetness system
-Makes wetness affect unconscious Oozlings.
-Removes flat bloodloss from getting wet.
-Fixes bug where core still broadcasting after crushing
-Fixes bug being unable to crush a core with a off gps
-Adds a bit of flavor text for crushing cores with off gps
- Ensures items are properly transferred to the core to prevent conflicts between overlapping movement mechanics. e.g. Chasms
-If the limb has an implant it will drop them to the floor instead of voiding it.
-Implants that go into the chest now drop unpon revival
-Cavity implant objects now drop unpon revival
-Fixes visual bugs caused by reviving a oozling core
-Minor grammar fixes
-Restores oozlings healing ability from plasma
-Heals 2.5 shared between heal and brute
-Healing is disabled by hydrophobia or if Oozlings skin reaches cold limit
-General refactoring
-Added filters for banned items and allowed implants and organs
-Fixes bug with Nuclear Authentation Disk. Resolve other protected items with the banned items list.
-External features (Not Anime Traits) such as tails wings antenna will be removed and stored in the core
@Coll6 Coll6 closed this Nov 23, 2024
@Coll6 Coll6 reopened this Nov 23, 2024
@Coll6 Coll6 changed the title Oozling qol fixes [DRAFT DNM]Oozling qol fixes Nov 23, 2024
@ThePooba
Copy link
Collaborator

Remove the clone damage stuff we dont really want that

@Kitsunemitsu Kitsunemitsu added Fix fix da bug Balance perfectly balanced as all things should be labels Dec 9, 2024
@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 27, 2024

Good question on how to handle the core ejection problem. But I think the good news is that the issues that this reaches to fix seems to not ahve been reported on again?

@MonkestationIssueBot MonkestationIssueBot mentioned this pull request Dec 27, 2024
@Coll6
Copy link
Contributor Author

Coll6 commented Dec 27, 2024

Good question on how to handle the core ejection problem. But I think the good news is that the issues that this reaches to fix seems to not ahve been reported on again?

No but since few play it's been hard to get bug reports. I think I know what I'll do for it so I'll try it later today.

@ThePooba ThePooba merged commit 7441a7a into Monkestation:master Dec 29, 2024
24 checks passed
github-actions bot added a commit that referenced this pull request Dec 29, 2024
@Coll6 Coll6 changed the title [DNM]Oozling qol fixes Oozling qol fixes Dec 29, 2024
@Coll6 Coll6 mentioned this pull request Dec 30, 2024
Gw0sty pushed a commit to Gw0sty/Monkestation2.0 that referenced this pull request Jan 9, 2025
* Restores Oozling wetness system. Bring a Towel.
-Restores dormant Oozling wetness system
-Makes wetness affect unconscious Oozlings.
-Removes flat bloodloss from getting wet.

* Oozling core gps Fix
-Fixes bug where core still broadcasting after crushing
-Fixes bug being unable to crush a core with a off gps
-Adds a bit of flavor text for crushing cores with off gps

* fix: Dup/Del Bug with chasms.
- Ensures items are properly transferred to the core to prevent conflicts between overlapping movement mechanics. e.g. Chasms

* fix: Limb implants being voided when dismemebered
-If the limb has an implant it will drop them to the floor instead of voiding it.

* Readds oozling melting from touch water sources.

* fix: Chest and Cavity implants. Revive visual bug
-Implants that go into the chest now drop unpon revival
-Cavity implant objects now drop unpon revival
-Fixes visual bugs caused by reviving a oozling core
-Minor grammar fixes

* Restores Oozling healing and tones it down
-Restores oozlings healing ability from plasma
-Heals 2.5 shared between heal and brute
-Healing is disabled by hydrophobia or if Oozlings skin reaches cold limit

* Refactor item core storage system
-General refactoring
-Added filters for banned items and allowed implants and organs
-Fixes bug with Nuclear Authentation Disk. Resolve other protected items with the banned items list.

* Allows external organs to be stored and saved
-External features (Not Anime Traits) such as tails wings antenna will be removed and stored in the core

* fix: Core can now case and store injector implants
-Oozling cores now recase injector implants before storing
-Minor fixes

* add: Oozlings scream and jitter upon revive

* fix: Resolves (Monkestation#4219)

* Minor text fix

* Removes hyno plasma remineder when souless.

* fix:Legions absorb oozling core and drops on death

* Should make gibbing deaths delete the core

* Fix Oozling ability status effects remaining

* Refix eyesight repair clean up from Monkestation#4584

* For code testing

* Refactored core item proccessing. Deep item filter

* Fixes quirk item duplications and rerolls

* Fixes hydrophobia blocking touch water

* bal moves revival effects to nugget revivals

* Properly removes and fixes blindess.

* Revival limb removal refeactor.
	-Moves the slime blood drop from drop_limb to dismemberment
	-nugget revival now uses drop_limb allowing for the body and UI to update properly.
	-head decapitations now drop contents except normal eyes
	-makes revival compatable with bright eyes. No more duping eyes.

* Various small fixes picked 09cc588 from PR Monkestation#4269

* Quick compat fix for TM Monkestation#4642
Gw0sty pushed a commit to Gw0sty/Monkestation2.0 that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment