Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revenant fails to take ghost player and add to the spawned revenant. #593

Closed
DexeeXI opened this issue Nov 22, 2023 · 2 comments · Fixed by #644
Closed

Revenant fails to take ghost player and add to the spawned revenant. #593

DexeeXI opened this issue Nov 22, 2023 · 2 comments · Fixed by #644

Comments

@DexeeXI
Copy link
Collaborator

DexeeXI commented Nov 22, 2023

Round ID:

2570

Testmerges:

#505 #537 #549 #578 #489

Reproduction:

  1. Use storyteller, attempt to spawn revenant
  2. Players receive notice to accept and become revenant
  3. Revenant is spawned in game world
  4. Chosen player fails to be placed into the revenant, no notice by server of who was chosen to be revenant
  5. Server sends "ADMIN LOG: An attempt to spawn revenant returned , this is a bug."

Additional Information

No visible runtimes were associated with this error.

@DexeeXI
Copy link
Collaborator Author

DexeeXI commented Nov 23, 2023

Additional comment: After providing a ghost player with the now spawned Revenant, it causes further issues, such that they are unable to drain bodies. Traitor panel reveals that they are properly assigned. Due to the loss of functionality, a further review of runtimes show something the following associated runtime:

[15:57:43] Runtime in code/modules/mob/mob.dm, line 548: Cannot read null.dynamic_lumcount
proc name: run examinate (/mob/proc/run_examinate)
usr: Bidlink2/(revenant (129))
usr.loc: (Medbay Treatment Center (127,102,3))
src: Ghost of peaceful salt (/mob/living/basic/revenant)
src.loc: the floor (127,102,3) (/turf/open/floor/iron/white)
call stack:
Ghost of peaceful salt (/mob/living/basic/revenant): run examinate(You shouldn't see this! (/obj/effect/abstract/interact))
/datum/callback/verb_callback (/datum/callback/verb_callback): InvokeAsync()
Ghost of peaceful salt (/mob/living/basic/revenant): Examine(You shouldn't see this! (/obj/effect/abstract/interact))
You shouldn't see this! (/obj/effect/abstract/interact): ShiftClick(Ghost of peaceful salt (/mob/living/basic/revenant))
Ghost of peaceful salt (/mob/living/basic/revenant): ShiftClickOn(You shouldn't see this! (/obj/effect/abstract/interact))
Ghost of peaceful salt (/mob/living/basic/revenant): ClickOn(You shouldn't see this! (/obj/effect/abstract/interact), "icon-x=20;icon-y=18;vis-x=18;v...")
You shouldn't see this! (/obj/effect/abstract/interact): Click(the floor (128,101,3) (/turf/open/floor/iron/white), "mapwindow.map", "icon-x=20;icon-y=18;vis-x=18;v...")
Bidlink2 (/client): Click(You shouldn't see this! (/obj/effect/abstract/interact), the floor (128,101,3) (/turf/open/floor/iron/white), "mapwindow.map", "icon-x=20;icon-y=18;vis-x=18;v...")

Further investigation is underway.

@DexeeXI
Copy link
Collaborator Author

DexeeXI commented Dec 3, 2023

tgstation/tgstation#78910

FIX ON TG IDENTIFIED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant