[MIRROR] Revenant Cleanup and Fixes Mistakes (#78910) #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request In large PRs (#78782 (3415828)), some mistakes tend to be made. Backend Fixes: * Removes excess and un-necessary `on_creation()` procs for the status effects. The work is already done in the parent `/datum/status_effect/revenant`, no need to duplicate it. User Facing Fixes: * I copy-pasted too hard and accidentally nerfed the holy hand grenade's effect on revenant. It was originally intended to stun for 10 seconds, and I had no interest in changing that to 2 seconds. My bad. * Revenant midrounds were broken because I thought observers had minds, whoops. I really wish there was a better way to transfer clients into a new mob than key mutations in these instances though. * Revenant Harvesting is fixed, because I forgot that we would be incapacitating the mob with the paralyze status effect. The proper flags are now passed into the `do_after()` and it should now give you delicious essence. ## Why It's Good For The Game Mea culpa. ## Changelog :cl: fix: The Holy Hand Grenade's effect on revealing a revenant had its duration accidentally nerfed, it is now back to 10 seconds. fix: Revenant midrounds should now properly run. fix: Revenant harvesting should now let you actually pass the final do_after so you can harvest that sweet essence. /:cl: Fixes #78925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
In large PRs (#78782 (3415828)), some mistakes tend to be made.
Backend Fixes:
on_creation()procs for the status effects. The work is already done in the parent/datum/status_effect/revenant, no need to duplicate it.User Facing Fixes:
do_after()and it should now give you delicious essence.Why It's Good For The Game
Mea culpa.
Changelog
🆑 san7890
fix: The Holy Hand Grenade's effect on revealing a revenant had its duration accidentally nerfed, it is now back to 10 seconds. fix: Revenant midrounds should now properly run.
fix: Revenant harvesting should now let you actually pass the final do_after so you can harvest that sweet essence.
/:cl:
Fixes #78925
Possibly fixes #593