Job rewards (should) now work properly #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernandoJ8
force-pushed
the
make-boofs-not-war
branch
from
bada567 to
bbf20dd
Compare
dwasint
reviewed
Jan 23, 2024
This was referenced Jan 23, 2024
Closed
This was referenced Jan 27, 2024
Closed
This was referenced Jan 28, 2024
This was referenced Jan 29, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Closes #358.
There were a few type mismatches here and there that made the code not work properly. It also moves the code that marks areward as collected to the end of the proc, so that it isn't counted as collected if we fail to add it to the DB and return early.
Both the loadout rewards and in-round rewards should be available to those who unlock them from now on, and a "Reload Job Rewards" verb has been added to hopefully fix it for people who have it already unlocked.
Also, I added a parenthesis to a check in
base_preferences.dm. It's unrelated to the rest of the changes, but I used the same check and found that it didn't actually skip the milestones from other jobs, since the syntax was off. Corrected it in both places.Why It's Good For The Game
Who doesn't like a bugfix?
Changelog
🆑
fix: loadout job rewards are now correctly added to the player's inventory.
fix: in-round job rewards are now obtainable in the same round they are unlocked.
add: The "Reload Job Rewards" verb is now available in the IC tab, to fix broken/missing job reward unlocks.
/:cl: