Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posession now does revive the dead and turns them into temporary vassals #1077

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

FernandoJ8
Copy link
Contributor

@FernandoJ8 FernandoJ8 commented Jan 27, 2024

About The Pull Request

What it says on the tin.
There's nothing else player facing (other than a balloon alert), but code-wise can_make_vassal() will now succeed even if the target is in hardcrit or worse. That check is now specific to the persuassion rack which is (currently) the only other way for someone to become a vassal.

Why It's Good For The Game

Closes #361.

Changelog

🆑
fix: Posession now revives those who are dead or in hard crit and turns them into temporary vassals
qol: Added a balloon alert that indicates when someone cannot be tortured in a persuasion rack due to being dead or in hard crit.
/:cl:

@JohnFulpWillard
Copy link
Contributor

if this is a bug on fulp can you port it

@FernandoJ8
Copy link
Contributor Author

if this is a bug on fulp can you port it

Yep.

@dwasint dwasint merged commit 36ce0c0 into Monkestation:master Mar 15, 2024
18 checks passed
github-actions bot added a commit that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tremere bloodsucker possession ability doesnt work
3 participants