The "Guide to Advanced Mimery" series now make but the faintest noise when turning their pages #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when turning their pages (tgstation#81068) ## About The Pull Request What it says on the tin. To fit with the description of volume 1 ("The pages don't make any sound when turned."), they now use the sound of faint rustling instead of the default page-turning sound effect. Pictured below (you may wish to turn up your volume): https://github.com/tgstation/tgstation/assets/80640114/e9867815-8e33-47a5-83e2-19fc979e15d6 ## Why It's Good For The Game Makes the book's behaviour consistent with their description, plus it's just fitting, isn't it?. ## Changelog :cl: sound: The Guide to Advanced Mimery book series now only make a very faint noise when turning their pages, in order to match their description /:cl:
|
I think I did this the right way with cherry-picking? Please do tell me if I didn't. |
Merged
via the queue into
Monkestation:master
with commit Feb 10, 2024
2ff9244
18 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
What it says on the tin, brought from upstream tgstation/tgstation#81068.
Why It's Good For The Game
Closes #584, makes the item's behaviour match their description.
Changelog
🆑
sound: The Guide to Advanced Mimery book series now only make a very faint noise when turning their pages, in order to match their description
/:cl: