Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QM is not a head #1266

Merged
merged 11 commits into from
Mar 2, 2024
Merged

QM is not a head #1266

merged 11 commits into from
Mar 2, 2024

Conversation

DexeeXI
Copy link
Collaborator

@DexeeXI DexeeXI commented Feb 22, 2024

About The Pull Request

QM is NOT a head. TG making QM a head was a mistake. We have previously reverted the majority of those changes. This finalizes the last few things to set QM up correctly. This PR will include changes to support non-head QM on our on-rotation maps, excluding Box Station as that is (as of 2/24) not merged and available for alternation.

Future required work:
1) likely to be done under this PR: fix maps for QM changes.
2) change closet data for QM locker to be just 2 or 3 things.
3) change other things as noticed.

This PR is not to be merged until it is full and complete. Test merge for single round obvious tests is allowed.

02/24: map edits. 90% of it cosmetic. will complete further alterations required.

Why It's Good For The Game

QM is NOT a head. Do you still want antag QMs? Then QM is NOT a head!

If the HOP wants to still have the QM on command chat, they can give them an encryption key.

Stock loadout
image

New SecHUD icon (gaudy as fuck by request)
image

Changelog

🆑
fix: QM is NOT a head.
fix: QM no longer has command related items on spawn.
fix: QM is not chain of command. No more biscuit.
fix: QM's SECHUD icon is no longer blue. It's improved, hope you appreciate the cringe.
fix: QM's PDA doesn't have bullshit programs on it anymore. In fact, it's a non-head PDA that has what you require to do your job.
fix: QM offices properly reflect their non-head status.
fix: Maid Cafe on Icebox had extra pipe causing a litany of issues. The extra pipe is now removed.
/:cl:

@DexeeXI
Copy link
Collaborator Author

DexeeXI commented Feb 24, 2024

Spoiler: I do not know why the blood brothers icon is being flagged as changed when I had not touched it what so ever.

new area for qm office, all qm offices now set to be cargo brown.
still not a ahead. commenting out the line because qm is not a head and does not deserve a head announcement.
@williamcll
Copy link

QM is head on TG because there's enough people per server that HOP has too many people to manage in the service department to care about cargo. I suppose it doesn't really matter on monke, yet.

@DexeeXI
Copy link
Collaborator Author

DexeeXI commented Feb 28, 2024

fucking integration tests failing on bars.

maid cafe had extra pipe. i take extra pipe out.
needed to replace space with a floor tile to stop tests from failing. otherwise ai has no cams for singularities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants