Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heretic improvements & QoL #1282

Merged
merged 4 commits into from
Mar 10, 2024
Merged

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Feb 25, 2024

Why It's Good For The Game

Makes heretics less of a pain in the ass, for both the heretics themselves and the victims

Changelog

🆑
balance: The heresy phobia from being sacrificed is now deep-rooted rather than permanent, meaning that it can be cured with a lobotomy.
balance: Victims in stamina crit are now also eligible for the heretic sacrifice rune.
qol: Heretic influences take longer to fade in (15 seconds -> 1 minute), and disappear after 10 minutes.
qol: Heretic sacrifices will now try to grab a corpse's ghost when trying to revive.
fix: Touching a tear in reality while being immune to dismemberment will just result in the arm being terribly wounded instead, avoiding a bug with the limb still being "there" despite being deleted.
balance: The Codex Cicatrix is now fully acid and fire-proof.
balance: Heretic armor and the void cloak are now fully acid and fire-proof.
qol: The beginning of the heretic sacrifice minigame will nullify any sorts of pre-existing stuns or sleeps, and prevent several external factors such as heart/liver problems, phobias, sedatives, epilepsy, or brain tumors from causing issues during the minigame.
balance: Ash heretics will no longer succumb to infections from burn wounds. The wound itself still remains an issue, it just won't get infected.
/:cl:

@Absolucy Absolucy force-pushed the heretic-improvements branch from f7a15c3 to 78fe40b Compare February 25, 2024 00:40
@Absolucy Absolucy force-pushed the heretic-improvements branch from 78fe40b to e76a076 Compare February 25, 2024 00:41
@Absolucy Absolucy closed this Feb 25, 2024
@Absolucy Absolucy reopened this Feb 25, 2024
@Yobrocharlie
Copy link

Yobrocharlie commented Mar 1, 2024

Besides the bug fixes this seems more like copecode than QoL fixes, and heretic robes don’t really need a buff considering they are strides and leaps better than anything the station can easily obtain and are very easy for the heretic to obtain.

it just seems like it makes it so heretics can just ignore a few actual game mechanics.

@Yobrocharlie
Copy link

After looking at the code changes by being a heretic and doing one ritual you can just permanently remove your brain trauma.

Don’t merge this PR in my opinion 👍

@Absolucy
Copy link
Member Author

Absolucy commented Mar 5, 2024

it just seems like it makes it so heretics can just ignore a few actual game mechanics.

@Yobrocharlie

The fireproofing is mostly so ash heretics (whose combat and abilities are based around setting the surrounding area and people on fire) won't get fucked up by their own abilities.

After looking at the code changes by being a heretic and doing one ritual you can just permanently remove your brain trauma.

Do... do you mean this?

/datum/status_effect/unholy_determination/on_apply()
	. = ..()
	owner.add_traits(list(TRAIT_SLEEPIMMUNE, TRAIT_FEARLESS, TRAIT_STABLEHEART, TRAIT_STABLELIVER, TRAIT_ANTICONVULSANT, TRAIT_TUMOR_SUPPRESSED), type)

This status effect is only ever active on victims of the heretic sacrifice minigame (when they're dodging the hands) - as soon as the minigame ends, these traits are removed and the victim will be affected by everything normally again.

@NotACoderSorry
Copy link

Besides the bug fixes this seems more like copecode than QoL fixes, and heretic robes don’t really need a buff considering they are strides and leaps better than anything the station can easily obtain and are very easy for the heretic to obtain.

See the problem is that on fire monkestation doesn't do very much damage to people, but absolutely shreds clothing, so ash heretic disproportionally backfire against themselves way worse than other heretics have it.

@dwasint dwasint merged commit c35a737 into Monkestation:master Mar 10, 2024
18 checks passed
github-actions bot added a commit that referenced this pull request Mar 10, 2024
@Absolucy Absolucy deleted the heretic-improvements branch March 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants