Port /tg/'s maptext/runechat improvements #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to replace our maptext font. Closes tgstation/tgstation#73002 Replaced with a pair of new fonts, made some improvements and fixes while we're at it. - Two new maptext fonts: Grand9K and TinyUnicode - These two scale cleanly with BYOND icon sizes, so no antialiasing of already tiny fonts making it look bad when enlarged on screen - Fixed size fonts now have metrics to be used properly on overlays (such as status display) where a client (a requirement for MeasureText) is not feasible - VCR OSD Mono still here, usable as a variable size font with larger text - Synchronizes status display scrolling speed between lines - Fixed special maptexts for yelling, clown, redtext, greentext https://github.com/tgstation/tgstation/assets/83487515/7dbaf1d1-f1d5-46ff-8903-d95cab059ed8 Maptext looks like crap if you're one of the players who no longer have the old font. Even if you do have Small Fonts, this looks better. :cl: LT3 refactor: Refactored maptext (those floating words) fix: Fixed special chat bubbles for yelling, clown, redtext, greentext fix: Fixed alignment of status display text code: Status displays now synchronize their message lines when scrolling /:cl:
- In PR tgstation/tgstation#76356 missed a few bits of maptext around, such as shuttle signs and the supermatter. Small text adjustments/fixes here. - Large amount of feedback about the context tooltips. Increases size, lightens default color as to not be too imposing. :cl: LT3 qol: Context tooltip size increased fix: Fixed remnants of old maptext code on various things /:cl:
## About The Pull Request Hopefully the last set of changes in this demonstration of the [Goldilocks principle](https://en.wikipedia.org/wiki/Goldilocks_principle). Some more font changes, the big (hah) one being the context tooltips again. - Context tooltips smaller main line, more compact sublines. - Improves documentation on the usage of the macros. - Removes incorrect comment I added earlier in tgstation.dme - Adds black outlines as default in the macros. - Icon sized letters (Dwarf Fortress, credits). - Deathrattle and other actions reduced spacing. - Aligned cooldowns/countdowns. <details> <summary>Screenshots</summary>        </details> ## Changelog :cl: LT3 image: More maptext and font tweaks spellcheck: Context tooltips too small, too big... just right? /:cl: --------- Co-authored-by: Jeremiah <[email protected]>
## About The Pull Request Fixes superscript characters from being invisible (like the asterisk when you perform actions)  ## Changelog :cl: LT3 fix: Maptext should now properly show superscript characters when performing actions /:cl:
## About The Pull Request This stuff has been cramping 100% heavy roleplay style for too long. Somehow, the way maptext is formatted* seems to break tag ends found around a line break. This usually happens when a space with width is found by the end of the line, and I don't recall ever encountering the issue otherwise. Apparently, I've also found out that concatenating two spaces, regardless of width, seems to fix the issue just fine, and that brings in the solution to this whole pedantic problem: a <b>zero-width space</b> at the end of the closing tag. *That's handled behind the curtains by the engine, so I can only throw wild guesses to why it happens. Oh, by the by, I've also changed the tip about text modifiers I've made over a year ago. It was too confusing to read.
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following:
Testing Evidence
Changelog
🆑 Absolucy, LT3, Ghommie
refactor: Refactored maptext (those floating words)
fix: Fixed special chat bubbles for yelling, clown, redtext, greentext
fix: Fixed alignment of status display text
code: Status displays now synchronize their message lines when scrolling
image: More maptext and font tweaks
spellcheck: Context tooltips too small, too big... just right?
fix: Maptext should now properly show superscript characters when performing actions
fix: Fixed text effects for runechat messages (the stuff enclosed in +, | and _ characters).
spellcheck: Improved the tip for say/text effects.
/:cl: