Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes yay #1349

Merged
merged 15 commits into from
Mar 16, 2024
Merged

Fixes yay #1349

merged 15 commits into from
Mar 16, 2024

Conversation

wraith-54321
Copy link
Collaborator

@wraith-54321 wraith-54321 commented Mar 6, 2024

About The Pull Request

Fixes some stuff
Ports tgstation/tgstation#80735, tgstation/tgstation#76277

Why It's Good For The Game

Changelog

🆑 vinylspiders, MrMelbert
/:cl:

wraith-54321 and others added 2 commits March 6, 2024 13:00
## About The Pull Request

At some point with the refactors to offering it was made so that
dropping the item stops the offer, unfortunately too slowing people with
high fives relied on this behavior (dropping not stopping the offer).

Restores that behavior with a bit more code tweaking. 

## Why It's Good For The Game

How can I be too slow?

## Changelog

:cl: Melbert
fix: You can once again "too slow" someone with a high five
/:cl:
@wraith-54321 wraith-54321 merged commit c449f76 into Monkestation:master Mar 16, 2024
19 checks passed
@wraith-54321 wraith-54321 deleted the code-is-borked branch March 17, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants