Fix cigarettes and tendrils #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request Fixes #78199 PR #78122 (ef44be8) was intended to allow you to smoke cigarettes in space if you have an oxygenated helmet on. What it _actually_ did was make it so you can _only_ smoke cigarettes if you have an oxygenated helmet on, regardless of whether or not you are in space (or if you inject them with liquid oxygen). I moved the shared check into a proc to reduce duplicate code and fixed the logic. ## Changelog :cl: fix: It is now possible to smoke cigarettes even if you aren't wearing a safety helmet /:cl:
## About The Pull Request adds an `else . = ..()` to spawner's attackby check so you can just break them with your crusher in case you need to be rid of it ## Why It's Good For The Game sometimes you just need to melee a spawner ## Changelog :cl: fix: Necropolis tendrils and other mining mob spawners can be hit in melee again. /:cl: --------- Co-authored-by: Hatterhat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Changelog
🆑
fix: Fixed cigarettes not being smokeable without a space helmet + internals.
fix: Fixed being unable to melee lavaland tendrils.
/:cl: