Gangs #1535
Open
Gangs #1535
+2,194
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request The easter rabbit event looped through every single landmark in the game, not checking for zlevel or purpose, just that they would not be called "blobspawn". This PR makes the logic more curated, using generic and maintenance event landmarks for normal bunnies, and carpspawn for space rabbits. Also added check_tick checks for a good measure. There is a still a lot of them! I counted around 50 bunnies on average per test. ## Why It's Good For The Game A more curated list is better than a list that checks for name strings. Ensures the rabbits spawn only on the station Z levels. ## Changelog :cl: code: Made the easter rabbits spawn on a more curated list. /:cl:
|
write a changelog raaaah |
This was referenced Aug 31, 2024
|
Can you put more effort in the PR description so people understand what you did? |
|
This PR is stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#82275
Also adds gangs
Why It's Good For The Game
: )
Changelog
🆑 Profakos
/:cl: