Refactor Jukebox Beacons #1548
Merged
Refactor Jukebox Beacons #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah so my last implementation... it was bad. This version entirely foregoes frankensteining code from everywhere and is just a slight modification of Roulette Beacon code. which is MUCH nicer. I also gave it its own custom icon!
wraith-54321
reviewed
Apr 1, 2024
code/game/objects/structures/crates_lockers/closets/secure/bar.dm
Outdated
Show resolved
Hide resolved
2/3 of the requested changes were also originated from roulette beacon code, so that should probably get a quick refactor too someday.
wraith-54321
reviewed
Apr 1, 2024
wraith-54321
reviewed
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Yeah, ill be honest, my last implementation of jukebox beacons kinda sucked, it was terrible, thats why i have
entirely redonestolen roulette beacon code and modded it slightly.This also comes with a new sprite! made by me, first time spriter, probably looks bad.
By the way this adds a wrench to the jukebox beacon as well so bartenders can move it after deployment.
Why It's Good For The
GameCodeDoesnt Stink.
Demonstration
jukeboxrefactordemonstration.mp4
Changelog
🆑 Tractor Mann
refactor: Jukebox Beacon Code has been refactored, changes to note is that jukeboxes no longer deploy instantly and now come with a wrench.
/:cl: