Remove purity adjustment for overdose thresholds #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🆑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Basically, fermichem has a hidden feature that automatically adjusts the overdose threshold for reagents based on their purity.
This PR removes that, because we don't have purity and also there are no mentions of this anywhere else in the game.
Why It's Good For The Game
It's a bad, hidden feature that turns all of our overdose thresholds into unpredictable decimals.
We don't even use the system that this implements anymore, so even if it was good, it's going into the trash anyway.
Changelog
🆑
fix: Remove purity adjustment for overdose thresholds, as we don't even use reagent purity here.
/:cl: