Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new MODsuit modules #1900

Closed
wants to merge 18 commits into from

Conversation

Uristthedorf
Copy link
Contributor

@Uristthedorf Uristthedorf commented May 12, 2024

Balance not done yet.

About The Pull Request

Adds new modules for MODsuits:

  • A security armor booster that has worse armor and doesn't increase speed, locked behind illegal tech.
  • A prototype energy shield that requires a gravitational anomaly to function. Is behind anomalock module tech.
  • A lube shoulder module, that's like pepper shoulder module, but sprays lube instead. Requires bananium to make. (Can also be purchased by clown ops.)

Makes some existing modules printable:

  • Pepper shoulders can now be printed.
  • Advanced EMP shield can be printed with illegal tech.

Why It's Good For The Game

Gives more options for your modsuit, pepper shoulders existing in already made sec modsuits but otherwise being unobtainable is weird, more anomaly locked modules is cool, grants more utility to illegal tech. Adds HONK factor with lube shoulders.

Changelog

🆑
add: Adds security armor booster module locked behind illegal tech.
add: Adds prototype energy shield that requires a gravitational anomaly.
add: Adds a lube shoulder module that sprays lube instead of pepperspray.
tweak: Pepper shoulder and advanced EMP module can now be printed.
/:cl:

Balance not done yet.
@Uristthedorf
Copy link
Contributor Author

Made as a draft because I feel like the new modules may need a balance pass.

@Uristthedorf Uristthedorf changed the title Adds modules Adds new MODsuit modules May 12, 2024
@Uristthedorf Uristthedorf marked this pull request as ready for review May 18, 2024 23:40
@Uristthedorf
Copy link
Contributor Author

No idea if this is balanced

Copy link
Collaborator

@F-e-r-n F-e-r-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of modularization needs to be done.

@@ -294,7 +294,7 @@
applied_core = /obj/item/mod/core/infinite
applied_modules = list(
/obj/item/mod/module/storage/large_capacity,
/obj/item/mod/module/energy_shield/wizard,
/obj/item/mod/module/anomaly_locked/energy_shield/wizard,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/obj/item/mod/module/anomaly_locked/energy_shield/wizard,
/obj/item/mod/module/anomaly_locked/energy_shield/wizard, //Monke Edit

Properly label edits

@@ -88,7 +88,7 @@
return ..()

///Energy Shield - Gives you a rechargeable energy shield that nullifies attacks.
/obj/item/mod/module/energy_shield
/obj/item/mod/module/anomaly_locked/energy_shield
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/obj/item/mod/module/anomaly_locked/energy_shield
/obj/item/mod/module/anomaly_locked/energy_shield //Monke Edit

^

Comment on lines +101 to +102
accepted_anomalies = list(/obj/item/assembly/signaler/anomaly/grav)
prebuilt = TRUE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
accepted_anomalies = list(/obj/item/assembly/signaler/anomaly/grav)
prebuilt = TRUE
//Monke edit start
accepted_anomalies = list(/obj/item/assembly/signaler/anomaly/grav)
prebuilt = TRUE
//Monke edit end

^

@@ -118,28 +119,28 @@
/// Charges the shield should start with.
var/charges

/obj/item/mod/module/energy_shield/Initialize(mapload)
/obj/item/mod/module/anomaly_locked/energy_shield/Initialize(mapload)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/obj/item/mod/module/anomaly_locked/energy_shield/Initialize(mapload)
/obj/item/mod/module/anomaly_locked/energy_shield/Initialize(mapload) //Monke edit

. = ..()
charges = max_charges

/obj/item/mod/module/energy_shield/on_suit_activation()
/obj/item/mod/module/anomaly_locked/energy_shield/on_suit_activation()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/obj/item/mod/module/anomaly_locked/energy_shield/on_suit_activation()
/obj/item/mod/module/anomaly_locked/energy_shield/on_suit_activation() //Monke edit

@@ -1783,6 +1784,7 @@
"mod_bikehorn",
"mod_microwave_beam",
"mod_waddle",
"mod_lubespray"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mod_lubespray"
"mod_lubespray" //Monke edit

@@ -1794,6 +1796,7 @@
design_ids = list(
"mod_antigrav",
"mod_teleporter",
"mod_energyshield",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mod_energyshield",
"mod_energyshield", //Monke edit

Comment on lines +2244 to +2245
"mod_crewarmor",
"mod_emp_shield_advanced",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mod_crewarmor",
"mod_emp_shield_advanced",
//monke edit start
"mod_crewarmor",
"mod_emp_shield_advanced",
//monke edit end

@@ -642,7 +642,7 @@
name = "MODsuit Energy Shield Module"
desc = "An energy shield module for a MODsuit. The shields can handle up to three impacts \
within a short duration and will rapidly recharge while not under fire."
item = /obj/item/mod/module/energy_shield
item = /obj/item/mod/module/anomaly_locked/energy_shield
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
item = /obj/item/mod/module/anomaly_locked/energy_shield
item = /obj/item/mod/module/anomaly_locked/energy_shield //Monke edit

code/modules/uplink/uplink_items/nukeops.dm Show resolved Hide resolved
@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 16, 2024

Stale PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants