[WIP] NTSL and Signal Technician #1945
Conversation
|
This PR may or may not be fixed. |
code/__DEFINES/logging.dm
Outdated
| @@ -51,6 +51,7 @@ | |||
| #define LOG_CLONING (1 << 22) | |||
| #define LOG_MECHCOMP (1 << 23) | |||
| #define LOG_BLACKMARKET (1 << 24) | |||
| #define LOG_NTSL (1 << 20) | |||
There was a problem hiding this comment.
we already have a 1<<20 needs to be 1<<25
There was a problem hiding this comment.
I am pretty sure I changed this; will fix.
| @@ -0,0 +1,3 @@ | |||
| /proc/log_ntsl(text) | |||
| if (CONFIG_GET(flag/log_ntsl)) | |||
| WRITE_LOG(GLOB.world_ntsl_log, "NTSL: [text]") | |||
There was a problem hiding this comment.
this should use the new logging system with Logger.Log
| var/mob/editingcode | ||
| var/mob/lasteditor | ||
| var/list/viewingcode = list() | ||
| var/obj/machinery/telecomms/server/SelectedServer |
There was a problem hiding this comment.
this doesn't appear to be unset in destroy which may lead to hard deletes
|
|
||
| //NTSL-related procs | ||
| /obj/machinery/telecomms/server/Initialize() | ||
| Compiler = new() |
There was a problem hiding this comment.
these don't appear to be cleared aswell
| /* | ||
| Class: node | ||
| */ | ||
| /node |
There was a problem hiding this comment.
should just make all these subtypes of datum.
There was a problem hiding this comment.
I tried this, it no longer compiled, and everything broke
Revert "Adds datum part 1" This reverts commit 2d0803d50dd068597d6ecad695234559520888a2. datumize Revert "Adds datum part 1" This reverts commit 76ebdf37543012697dd0ad02d982deb79faa35a4.
|
Okay, I'm going to need help fixing linters on this. |
|
Okay so Gonna put this on the backburner. |
About The Pull Request
Ports in the NTSL coding language and a role to accompany it; Signal Technician.
So this is a port, of a port of a port, let me give the full lineage.
First, credit goes to Yogstation, for the concept of NTSL.
Then, Skyrat in Skyrat-SS13/Skyrat-tg#5095
Then it was ported by yours truly to Bungalow/Quasar in Quasar-13/Quasar-13#133
And finally, Here again by me.
Signal Technician is a role that does 2 main things:
Maintain Telecommunications
Write code in their greasy tcomms den.
TODO:
Why It's Good For The Game
First, this will encourage people to actually know how to fix Tcomms. I have only ever met two people in my over 1000 hrs of SS13 that could fix tcomms.
Tcomms goes down multiple times each shift; and signal technician will hopefully know how to fix it.
Second, NTSL is simply a cool system.
Designing and testing new code on a live "server" (the Tcomms) is interesting and cool.
Changelog
🆑
add: Added NTSL
add: Added Signal Technician
/:cl: