Improvised Gun Improvement #2010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And typo fix.
Bayonet offset, and fixes a bug where it might balloon "can't jam" and "bolt closed" at the same time.
KittyNoodle
reviewed
May 26, 2024
| @@ -346,6 +346,7 @@ GLOBAL_LIST_INIT(rarity_loot, list(//rare: really good items | |||
| /obj/item/book/granter/crafting_recipe/maint_gun/pipegun_prime = 1, | |||
| /obj/item/book/granter/crafting_recipe/trash_cannon = 1, | |||
| /obj/item/book/granter/crafting_recipe/maint_gun/laser_musket_prime = 1, | |||
| /obj/item/book/granter/crafting_recipe/maint_gun/smoothbore_disabler_prime = 1, | |||
There was a problem hiding this comment.
excluded for a reason when i added these to maints.
There was a problem hiding this comment.
because its very powerful and you can get the book through black market instead(rarely)
There was a problem hiding this comment.
I've never seen them be an issue, and there's nothing wrong with there being more than one way to get it. Cargo's the only people who can order the black market transceiver thing I think, so giving others a method to get one is nice.
|
I think I might have to build this from the ground up again to have it be modularized. |
|
Made a more modulized version of this PR (#2026) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This makes improvised guns both more effective and easier to craft.
Laser Muskets:
-Prescription Glasses can now be printed at autolathes and medical lathes.
-Standard, Prime, and Syndicate have a wound_bonus of -10, from -30. (Might be too much.)
Pipeguns:
-Regal Pipegun no longer requires you to have an assistant cosplay to craft.
-The spear is now considered a tool, not an ingredient for regal pipegun.
Smoothbore Disablers:
-Prime version no longer requires chemicals to craft.
-The recipe for smoothbore disabler can now be found in maintenance.
Maintenance sect now has a ritual that lets them get the books that grant you the crafting recipes for improved improvised guns.
Ports some improvements from TG for rifle.dm, that fixes bayonet offset for pipeguns, and fixes a bug that lets it balloon "can't jam" and "bolt closed" at the same time.
Other:
-Prescription Glasses can now be printed at medical lathes and autolathes.
-Sticky Tape can now be bought from YouTool and engivendor. (You would find tape at a hardware store.)
-Paint moved from rare maint loot category to uncommon. (Why would paint be as common as a book telling you how to make fancy guns?)
-More knives can be used as bayonets, allowing for ghetto bayonets.
-The recipe granters for improvised guns are now 50% likely to be available at black market (from 40%,) and have a maximum availability of 3.
-The part vendor at tool storage has more parts.
Why It's Good For The Game
For the amount of effort it takes to make an improvised gun, you might have well just bought a russian crate or something from cargo. This is especially true for the elite versions of improvised guns, which are very difficult to get, but still are vastly inferior to stuff you could easily get from cargo. Some of the requirements for crafting are rather insane, such as the regal pipegun requiring an assistant cosplay to craft.
This makes improvised guns more worthwhile to craft.
Changelog
🆑
add: Prescription glasses can now be printed at autolathes and medical lathes.
add: Sticky Tape can now be bought at YouTool and Engievendor.
add: More kinds of knives can be used as bayonets.
add: Maintenance Sect has a ritual to get recipe books for elite improvised guns.
balance: Elite versions of improvised guns are now more effective and easier to craft.
fix: Fixed pipegun bayonet offset
fix: Fixed a bug where a bolt action rifle (mosin/pipegun) might balloon both "can't jam" and "bolt closed" at the same time.
/:cl: