-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Flavor Text and Records, 2nd attempt #2093
Merged
dwasint
merged 8 commits into
Monkestation:master
from
Hardly3D:revert-1864-revert-1825-flavortext
Jun 21, 2024
Merged
Adds Flavor Text and Records, 2nd attempt #2093
dwasint
merged 8 commits into
Monkestation:master
from
Hardly3D:revert-1864-revert-1825-flavortext
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 7, 2024
Would it be possible to increase the maximum length of records? Can't fit mine. |
This was referenced Jun 8, 2024
Closed
Closed
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
Gboster-0
reviewed
Jun 17, 2024
This was referenced Jun 18, 2024
Closed
Closed
Co-authored-by: Gboster-0 <[email protected]>
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Last PR had a big issue which led the server to lag a lot which led to it's reversion, it should be fixed from testing it but even then I highly advise TMing this and reporting any issues that may come out of this.
OG description below since it's pretty much the same
Ports Maplestation's flavor text to Monkestation
MrMelbert/MapleStationCode#4
MrMelbert/MapleStationCode#31
MrMelbert/MapleStationCode#44
MrMelbert/MapleStationCode#93
MrMelbert/MapleStationCode#97
MrMelbert/MapleStationCode#217
MrMelbert/MapleStationCode#315
All players can now add text to describe their character which will be shown when examined, the flavor text will be hidden when wearing something to hide the face alongside the ID. Admins who are ghosting can still see all of them, regardless of whenever they are masked or not.
Only antags can see Exploitable info, which allows them to know a character's weakness, allowing them to gain leverage (eg. bringing up blackmail, debt, getting them to comply)
General Records is shown on every record console, medical and security to their respective department's
Why It's Good For The Game
Allows players to describe their character in ways that 32x32 pixel can't, working as a great tool for RP.
Examine text used to be a feature from Monkestation 1.0, this brings it back alongside expanding upon it by adding records, allowing players to come up with backstories, criminal records and so on, which may make it handy for RP roles like Warden and Psychiatrist.
Changelog
🆑 MrMelbert, NikoTheDude, Ported by Hardly
add: Added examine text, describe your character in ways that a 32x32 sprite can't!
add: Added temporary examine text alongside an indicator
add: Added character records text
admin: Admins can see all flavor texts of a character
/:cl: