IPCs can now have a gender set, and thus have pronouns #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents issues with the game giving you a gender, or people assuming their characters will still be PLURAL when they might not be.
|
Stale PR. |
|
@DexeeXI If I remember correctly, I believe this PR is considered finished and ready to merge. That said, I do want to point out that I have no intention of touching this repository for the foreseeable future (and thus, this PR). So if it starts conflicting before it's merged, I will not be fixing the merge conflict. |
|
Sounds good, Ill Tm and see how it works out! |
|
Since it's been a while since I committed this code, I'm not confident it'll work simply by fixing the merge conflicts. So, I'm going to close this issue, and open a new one soon with the appropriate changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Previously, IPCs were always stuck to they/them. In a sense, this made sense - they're robots. However, in the year of 2564 (or whatever it was), as IPCs become more plentiful, and the people become more accepting, it's only natural that some IPCs may choose to go by she/her or he/him.
This PR makes changes to that effect. To prevent existing characters from being affected, a savedata migration was added that affects any IPCs whose
modular_versionwas less than4, setting their gender to PLURAL.This PR also fixes modular savefile updates, so that they actually update the savefile.
Why It's Good For The Game
IPCs can have pronouns now.
Changelog
🆑 MichiRecRoom
add: IPCs can now have a gender set. Existing IPCs will (until manually updated) default to Other (they/them) to match previous behavior, and new IPCs will be given a random gender. This has no visual effect - it only affects their pronouns!
/:cl: